Fix generator missing parens around an arrow returning function type (#…

…10519)
babel · Oct 12, 2019 · e28c8ac · e28c8ac
1 parent 99035ca
commit e28c8ac
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/packages/babel-generator/src/node/parentheses.js b/packages/babel-generator/src/node/parentheses.js
@@ -35,14 +35,22 @@ export function NullableTypeAnnotation(node: Object, parent: Object): boolean {
   return t.isArrayTypeAnnotation(parent);
 }
 
-export function FunctionTypeAnnotation(node: Object, parent: Object): boolean {
+export function FunctionTypeAnnotation(
+  node: Object,
+  parent: Object,
+  printStack: Array<Object>,
+): boolean {
   return (
     // (() => A) | (() => B)
     t.isUnionTypeAnnotation(parent) ||
     // (() => A) & (() => B)
     t.isIntersectionTypeAnnotation(parent) ||
     // (() => A)[]
-    t.isArrayTypeAnnotation(parent)
+    t.isArrayTypeAnnotation(parent) ||
+    // <T>(A: T): (T => T[]) => B => [A, B]
+    (t.isTypeAnnotation(parent) &&
+      // Check grandparent
+      t.isArrowFunctionExpression(printStack[printStack.length - 3]))
   );
 }
 

diff --git a/packages/babel-generator/test/fixtures/flow/arrow-functions/input.js b/packages/babel-generator/test/fixtures/flow/arrow-functions/input.js
@@ -5,3 +5,4 @@ const bar4 = x => {};
 const bar5 = (x): string => {};
 const bar6 = (x: number) => {};
 const bar7 = <T>(x) => {};
+const bar8 = <T>(x: T): (T => T[]) => y => [x, y];
diff --git a/packages/babel-generator/test/fixtures/flow/arrow-functions/output.js b/packages/babel-generator/test/fixtures/flow/arrow-functions/output.js
@@ -10,4 +10,6 @@ const bar5 = (x): string => {};
 
 const bar6 = (x: number) => {};
 
-const bar7 = <T>(x) => {};
+const bar7 = <T>(x) => {};
+
+const bar8 = <T>(x: T): ((T) => T[]) => y => [x, y];