fix: ExpressionBody should respect [In] parameter

babel · Aug 10, 2020 · dd3da42 · dd3da42
1 parent 4bb1e16
commit dd3da42
Show file tree

Hide file tree

Showing 5 changed files with 97 additions and 1 deletion.
diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js
@@ -2115,7 +2115,8 @@ export default class ExpressionParser extends LValParser {
     this.state.inParameters = false;
 
     if (isExpression) {
-      node.body = this.parseMaybeAssignAllowIn();
+      // https://tc39.es/ecma262/#prod-ExpressionBody
+      node.body = this.parseMaybeAssign();
       this.checkParams(node, false, allowExpression, false);
     } else {
       const oldStrict = this.state.strict;

diff --git a/packages/babel-parser/test/fixtures/es2015/arrow-functions/concise-body-binary-in/input.js b/packages/babel-parser/test/fixtures/es2015/arrow-functions/concise-body-binary-in/input.js
@@ -0,0 +1,3 @@
+const t = () => ({
+  v: (v) => v in z
+})
diff --git a/...ages/babel-parser/test/fixtures/es2015/arrow-functions/concise-body-binary-in/output.json b/...ages/babel-parser/test/fixtures/es2015/arrow-functions/concise-body-binary-in/output.json
@@ -0,0 +1,88 @@
+{
+  "type": "File",
+  "start":0,"end":40,"loc":{"start":{"line":1,"column":0},"end":{"line":3,"column":2}},
+  "program": {
+    "type": "Program",
+    "start":0,"end":40,"loc":{"start":{"line":1,"column":0},"end":{"line":3,"column":2}},
+    "sourceType": "script",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "VariableDeclaration",
+        "start":0,"end":40,"loc":{"start":{"line":1,"column":0},"end":{"line":3,"column":2}},
+        "declarations": [
+          {
+            "type": "VariableDeclarator",
+            "start":6,"end":40,"loc":{"start":{"line":1,"column":6},"end":{"line":3,"column":2}},
+            "id": {
+              "type": "Identifier",
+              "start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7},"identifierName":"t"},
+              "name": "t"
+            },
+            "init": {
+              "type": "ArrowFunctionExpression",
+              "start":10,"end":40,"loc":{"start":{"line":1,"column":10},"end":{"line":3,"column":2}},
+              "id": null,
+              "generator": false,
+              "async": false,
+              "params": [],
+              "body": {
+                "type": "ObjectExpression",
+                "start":17,"end":39,"loc":{"start":{"line":1,"column":17},"end":{"line":3,"column":1}},
+                "properties": [
+                  {
+                    "type": "ObjectProperty",
+                    "start":21,"end":37,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":18}},
+                    "method": false,
+                    "key": {
+                      "type": "Identifier",
+                      "start":21,"end":22,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":3},"identifierName":"v"},
+                      "name": "v"
+                    },
+                    "computed": false,
+                    "shorthand": false,
+                    "value": {
+                      "type": "ArrowFunctionExpression",
+                      "start":24,"end":37,"loc":{"start":{"line":2,"column":5},"end":{"line":2,"column":18}},
+                      "id": null,
+                      "generator": false,
+                      "async": false,
+                      "params": [
+                        {
+                          "type": "Identifier",
+                          "start":25,"end":26,"loc":{"start":{"line":2,"column":6},"end":{"line":2,"column":7},"identifierName":"v"},
+                          "name": "v"
+                        }
+                      ],
+                      "body": {
+                        "type": "BinaryExpression",
+                        "start":31,"end":37,"loc":{"start":{"line":2,"column":12},"end":{"line":2,"column":18}},
+                        "left": {
+                          "type": "Identifier",
+                          "start":31,"end":32,"loc":{"start":{"line":2,"column":12},"end":{"line":2,"column":13},"identifierName":"v"},
+                          "name": "v"
+                        },
+                        "operator": "in",
+                        "right": {
+                          "type": "Identifier",
+                          "start":36,"end":37,"loc":{"start":{"line":2,"column":17},"end":{"line":2,"column":18},"identifierName":"z"},
+                          "name": "z"
+                        }
+                      }
+                    }
+                  }
+                ],
+                "extra": {
+                  "parenthesized": true,
+                  "parenStart": 16
+                }
+              }
+            }
+          }
+        ],
+        "kind": "const"
+      }
+    ],
+    "directives": []
+  }
+}
diff --git a/...bel-parser/test/fixtures/es2015/arrow-functions/no-for-in-init-concise-binary-in/input.js b/...bel-parser/test/fixtures/es2015/arrow-functions/no-for-in-init-concise-binary-in/input.js
@@ -0,0 +1 @@
+for (() => x in y;;);
diff --git a/...parser/test/fixtures/es2015/arrow-functions/no-for-in-init-concise-binary-in/options.json b/...parser/test/fixtures/es2015/arrow-functions/no-for-in-init-concise-binary-in/options.json
@@ -0,0 +1,3 @@
+{
+  "throws": "Unexpected token, expected \")\" (1:17)"
+}