V8intrinsic syntax plugin (#10148)

* feat: v8intrinsic syntax plugin Implement V8 Intrinsic Syntax Extension. Here we check the execution branch inside the parseSubscript to make sure the V8IntrinsicIdentifier is immediately followed by a call expression. * feat: disable combining placeholders and v8intrisic per #10104 (comment) * test: add more error cases * refactor: parse v8 intrinsic in parseExprAtom This approach is identical to V8’s implementation. Move the test cases as the behaviour changes. * fix: plugin-name typo * test: add yield-expression test case * feat: require startsExpr on modulo for v8intrinsic * perf: skip eof and braceR check as they must return false * Print V8IntrinsicIdentifier * feat: add v8intrinsic to parser typings * Add generated type helpers * fix: incorrect type definition * fix: allow V8IntrinsicIdentifier to be callee
babel · Sep 6, 2019 · da0af5f · da0af5f
1 parent b02e35c
commit da0af5f
Show file tree

Hide file tree

Showing 38 changed files with 961 additions and 5 deletions.
diff --git a/packages/babel-generator/src/generators/expressions.js b/packages/babel-generator/src/generators/expressions.js
@@ -264,3 +264,8 @@ export function PrivateName(node: Object) {
   this.token("#");
   this.print(node.id, node);
 }
+
+export function V8IntrinsicIdentifier(node: Object) {
+  this.token("%");
+  this.word(node.name);
+}
diff --git a/packages/babel-generator/test/fixtures/misc/V8IntrinsicIdentifier/input.js b/packages/babel-generator/test/fixtures/misc/V8IntrinsicIdentifier/input.js
@@ -0,0 +1 @@
+%DebugPrint(foo);
diff --git a/packages/babel-generator/test/fixtures/misc/V8IntrinsicIdentifier/options.json b/packages/babel-generator/test/fixtures/misc/V8IntrinsicIdentifier/options.json
@@ -0,0 +1,3 @@
+{
+  "plugins": ["v8intrinsic"]
+}
diff --git a/packages/babel-generator/test/fixtures/misc/V8IntrinsicIdentifier/output.js b/packages/babel-generator/test/fixtures/misc/V8IntrinsicIdentifier/output.js
@@ -0,0 +1 @@
+%DebugPrint(foo);
diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js
@@ -2191,7 +2191,7 @@ export default class ExpressionParser extends LValParser {
     if (
       this.match(tt.semi) ||
       (!this.match(tt.star) && !this.state.type.startsExpr) ||
-      this.canInsertSemicolon()
+      this.hasPrecedingLineBreak()
     ) {
       node.delegate = false;
       node.argument = null;

diff --git a/packages/babel-parser/src/plugin-utils.js b/packages/babel-parser/src/plugin-utils.js
@@ -69,6 +69,10 @@ export function validatePlugins(plugins: PluginList) {
     throw new Error("Cannot combine flow and typescript plugins.");
   }
 
+  if (hasPlugin(plugins, "placeholders") && hasPlugin(plugins, "v8intrinsic")) {
+    throw new Error("Cannot combine placeholders and v8intrinsic plugins.");
+  }
+
   if (
     hasPlugin(plugins, "pipelineOperator") &&
     !PIPELINE_PROPOSALS.includes(
@@ -89,13 +93,15 @@ import flow from "./plugins/flow";
 import jsx from "./plugins/jsx";
 import typescript from "./plugins/typescript";
 import placeholders from "./plugins/placeholders";
+import v8intrinsic from "./plugins/v8intrinsic";
 
 // NOTE: order is important. estree must come first; placeholders must come last.
 export const mixinPlugins: { [name: string]: MixinPlugin } = {
   estree,
   jsx,
   flow,
   typescript,
+  v8intrinsic,
   placeholders,
 };
 

diff --git a/packages/babel-parser/src/plugins/v8intrinsic.js b/packages/babel-parser/src/plugins/v8intrinsic.js
@@ -0,0 +1,32 @@
+import type Parser from "../parser";
+import { types as tt } from "../tokenizer/types";
+import * as N from "../types";
+
+export default (superClass: Class<Parser>): Class<Parser> =>
+  class extends superClass {
+    parseV8Intrinsic(): N.Expression {
+      if (this.match(tt.modulo)) {
+        const v8IntrinsicStart = this.state.start;
+        // let the `loc` of Identifier starts from `%`
+        const node = this.startNode();
+        this.eat(tt.modulo);
+        if (this.match(tt.name)) {
+          const name = this.parseIdentifierName(this.state.start);
+          const identifier = this.createIdentifier(node, name);
+          identifier.type = "V8IntrinsicIdentifier";
+          if (this.match(tt.parenL)) {
+            return identifier;
+          }
+        }
+        this.unexpected(v8IntrinsicStart);
+      }
+    }
+
+    /* ============================================================ *
+     * parser/expression.js                                         *
+     * ============================================================ */
+
+    parseExprAtom(): N.Expression {
+      return this.parseV8Intrinsic() || super.parseExprAtom(...arguments);
+    }
+  };
diff --git a/packages/babel-parser/src/tokenizer/types.js b/packages/babel-parser/src/tokenizer/types.js
@@ -148,7 +148,8 @@ export const types: { [name: string]: TokenType } = {
   relational: createBinop("</>/<=/>=", 8),
   bitShift: createBinop("<</>>/>>>", 9),
   plusMin: new TokenType("+/-", { beforeExpr, binop: 10, prefix, startsExpr }),
-  modulo: createBinop("%", 11),
+  // startsExpr: required by v8intrinsic plugin
+  modulo: new TokenType("%", { beforeExpr, binop: 11, startsExpr }),
   star: createBinop("*", 11),
   slash: createBinop("/", 11),
   exponent: new TokenType("**", {

diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/_errors/in-bind-expression/input.js b/packages/babel-parser/test/fixtures/v8intrinsic/_errors/in-bind-expression/input.js
@@ -0,0 +1 @@
+::%DebugPrint(null)
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/_errors/in-bind-expression/options.json b/packages/babel-parser/test/fixtures/v8intrinsic/_errors/in-bind-expression/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "v8intrinsic"
+  ],
+  "throws": "Unexpected token (1:0)"
+}
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/_errors/in-member-expression/input.js b/packages/babel-parser/test/fixtures/v8intrinsic/_errors/in-member-expression/input.js
@@ -0,0 +1 @@
+a.%DebugPrint();
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/_errors/in-member-expression/options.json b/packages/babel-parser/test/fixtures/v8intrinsic/_errors/in-member-expression/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "v8intrinsic"
+  ],
+  "throws": "Unexpected token (1:2)"
+}
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/_errors/no-plugin/input.js b/packages/babel-parser/test/fixtures/v8intrinsic/_errors/no-plugin/input.js
@@ -0,0 +1 @@
+%DebugPrint(foo)
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/_errors/no-plugin/options.json b/packages/babel-parser/test/fixtures/v8intrinsic/_errors/no-plugin/options.json
@@ -0,0 +1,4 @@
+{
+  "plugins": [],
+  "throws": "Unexpected token (1:0)"
+}
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/_errors/not-in-call-expression/input.js b/packages/babel-parser/test/fixtures/v8intrinsic/_errors/not-in-call-expression/input.js
@@ -0,0 +1,2 @@
+const i = %DebugPrint;
+i(foo);
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/_errors/not-in-call-expression/options.json b/packages/babel-parser/test/fixtures/v8intrinsic/_errors/not-in-call-expression/options.json
@@ -0,0 +1,4 @@
+{
+  "plugins": ["v8intrinsic"],
+  "throws": "Unexpected token (1:10)"
+}
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/_errors/optional-call-expression/input.js b/packages/babel-parser/test/fixtures/v8intrinsic/_errors/optional-call-expression/input.js
@@ -0,0 +1 @@
+%DebugPrint?.(null)
diff --git a/...ages/babel-parser/test/fixtures/v8intrinsic/_errors/optional-call-expression/options.json b/...ages/babel-parser/test/fixtures/v8intrinsic/_errors/optional-call-expression/options.json
@@ -0,0 +1,7 @@
+{
+  "plugins": [
+    "optionalChaining",
+    "v8intrinsic"
+  ],
+  "throws": "Unexpected token (1:0)"
+}
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/expression/await-expression/input.js b/packages/babel-parser/test/fixtures/v8intrinsic/expression/await-expression/input.js
@@ -0,0 +1 @@
+async () => { await %StringParseInt("42", 10) }
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/expression/await-expression/output.json b/packages/babel-parser/test/fixtures/v8intrinsic/expression/await-expression/output.json
@@ -0,0 +1,191 @@
+{
+  "type": "File",
+  "start": 0,
+  "end": 47,
+  "loc": {
+    "start": {
+      "line": 1,
+      "column": 0
+    },
+    "end": {
+      "line": 1,
+      "column": 47
+    }
+  },
+  "program": {
+    "type": "Program",
+    "start": 0,
+    "end": 47,
+    "loc": {
+      "start": {
+        "line": 1,
+        "column": 0
+      },
+      "end": {
+        "line": 1,
+        "column": 47
+      }
+    },
+    "sourceType": "script",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExpressionStatement",
+        "start": 0,
+        "end": 47,
+        "loc": {
+          "start": {
+            "line": 1,
+            "column": 0
+          },
+          "end": {
+            "line": 1,
+            "column": 47
+          }
+        },
+        "expression": {
+          "type": "ArrowFunctionExpression",
+          "start": 0,
+          "end": 47,
+          "loc": {
+            "start": {
+              "line": 1,
+              "column": 0
+            },
+            "end": {
+              "line": 1,
+              "column": 47
+            }
+          },
+          "id": null,
+          "generator": false,
+          "async": true,
+          "params": [],
+          "body": {
+            "type": "BlockStatement",
+            "start": 12,
+            "end": 47,
+            "loc": {
+              "start": {
+                "line": 1,
+                "column": 12
+              },
+              "end": {
+                "line": 1,
+                "column": 47
+              }
+            },
+            "body": [
+              {
+                "type": "ExpressionStatement",
+                "start": 14,
+                "end": 45,
+                "loc": {
+                  "start": {
+                    "line": 1,
+                    "column": 14
+                  },
+                  "end": {
+                    "line": 1,
+                    "column": 45
+                  }
+                },
+                "expression": {
+                  "type": "AwaitExpression",
+                  "start": 14,
+                  "end": 45,
+                  "loc": {
+                    "start": {
+                      "line": 1,
+                      "column": 14
+                    },
+                    "end": {
+                      "line": 1,
+                      "column": 45
+                    }
+                  },
+                  "argument": {
+                    "type": "CallExpression",
+                    "start": 20,
+                    "end": 45,
+                    "loc": {
+                      "start": {
+                        "line": 1,
+                        "column": 20
+                      },
+                      "end": {
+                        "line": 1,
+                        "column": 45
+                      }
+                    },
+                    "callee": {
+                      "type": "V8IntrinsicIdentifier",
+                      "start": 20,
+                      "end": 35,
+                      "loc": {
+                        "start": {
+                          "line": 1,
+                          "column": 20
+                        },
+                        "end": {
+                          "line": 1,
+                          "column": 35
+                        },
+                        "identifierName": "StringParseInt"
+                      },
+                      "name": "StringParseInt"
+                    },
+                    "arguments": [
+                      {
+                        "type": "StringLiteral",
+                        "start": 36,
+                        "end": 40,
+                        "loc": {
+                          "start": {
+                            "line": 1,
+                            "column": 36
+                          },
+                          "end": {
+                            "line": 1,
+                            "column": 40
+                          }
+                        },
+                        "extra": {
+                          "rawValue": "42",
+                          "raw": "\"42\""
+                        },
+                        "value": "42"
+                      },
+                      {
+                        "type": "NumericLiteral",
+                        "start": 42,
+                        "end": 44,
+                        "loc": {
+                          "start": {
+                            "line": 1,
+                            "column": 42
+                          },
+                          "end": {
+                            "line": 1,
+                            "column": 44
+                          }
+                        },
+                        "extra": {
+                          "rawValue": 10,
+                          "raw": "10"
+                        },
+                        "value": 10
+                      }
+                    ]
+                  }
+                }
+              }
+            ],
+            "directives": []
+          }
+        }
+      }
+    ],
+    "directives": []
+  }
+}
diff --git a/packages/babel-parser/test/fixtures/v8intrinsic/expression/call-expression/input.js b/packages/babel-parser/test/fixtures/v8intrinsic/expression/call-expression/input.js
@@ -0,0 +1 @@
+%DebugPrint(foo)