Skip to content

Commit

Permalink
Add tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@nicolo-ribaudo
nicolo-ribaudo committed Oct 23, 2019
1 parent afcf177 commit c98dca5
Show file tree
Hide file tree
Showing 16 changed files with 122 additions and 147 deletions.
246 changes: 114 additions & 132 deletions packages/babel-core/test/config-chain.js
View file
@@ -1,4 +1,5 @@
import fs from "fs";
import os from "os";
import path from "path";
import escapeRegExp from "lodash/escapeRegExp";
import { loadOptions as loadOptionsOrig } from "../lib";
Expand All @@ -14,6 +15,24 @@ function loadOptions(opts) {
});
}

function pairs(items) {
const pairs = [];
for (let i = 0; i < items.length - 1; i++) {
for (let j = i + 1; j < items.length; j++) {
pairs.push([items[i], items[j]]);
}
}
return pairs;
}

async function getTemp(name) {
const cwd = await fs.promises.mkdtemp(os.tmpdir() + path.sep + name);
const tmp = name => path.join(cwd, name);
const config = name =>
fs.promises.copyFile(fixture("config-files-templates", name), tmp(name));
return { cwd, tmp, config };
}

describe("buildConfigChain", function() {
describe("test", () => {
describe("single", () => {
Expand Down Expand Up @@ -944,157 +963,120 @@ describe("buildConfigChain", function() {
}
});

it("should load babel.config.json", () => {
const filename = fixture("config-files", "babel-config-json", "src.js");
describe("root", () => {
test.each(["babel.config.json", "babel.config.js", "babel.config.cjs"])(
"should load %s",
async name => {
const { cwd, tmp, config } = await getTemp(
`babel-test-load-config-${name}`,
);
const filename = tmp("src.js");

await config(name);

expect(
loadOptions({
filename,
cwd,
}),
).toEqual({
...getDefaults(),
filename,
cwd,
root: cwd,
comments: true,
});
},
);

expect(
loadOptions({
filename,
cwd: path.dirname(filename),
}),
).toEqual({
...getDefaults(),
filename: filename,
cwd: path.dirname(filename),
root: path.dirname(filename),
comments: true,
});
});
test.each(
pairs(["babel.config.json", "babel.config.js", "babel.config.cjs"]),
)("should throw if both %s and %s are used", async (name1, name2) => {
const { cwd, tmp, config } = await getTemp(
`babel-test-dup-config-${name1}-${name2}`,
);

it("should load babel.config.js", () => {
const filename = fixture("config-files", "babel-config-js", "src.js");
await Promise.all([config(name1), config(name2)]);

expect(
loadOptions({
filename,
cwd: path.dirname(filename),
}),
).toEqual({
...getDefaults(),
filename: filename,
cwd: path.dirname(filename),
root: path.dirname(filename),
comments: true,
expect(() => loadOptions({ filename: tmp("src.js"), cwd })).toThrow(
/Multiple configuration files found/,
);
});
});

it("should whtow if both babel.config.json and babel.config.js are used", () => {
const filename = fixture(
"config-files",
"babel-config-js-and-json",
"src.js",
describe("relative", () => {
test.each(["package.json", ".babelrc", ".babelrc.js", ".babelrc.cjs"])(
"should load %s",
async name => {
const { cwd, tmp, config } = await getTemp(
`babel-test-load-config-${name}`,
);
const filename = tmp("src.js");

await config(name);

expect(
loadOptions({
filename,
cwd,
}),
).toEqual({
...getDefaults(),
filename,
cwd,
root: cwd,
comments: true,
});
},
);

expect(() =>
loadOptions({ filename, cwd: path.dirname(filename) }),
).toThrow(/Multiple configuration files found/);
});
it("should load .babelignore", () => {
const filename = fixture("config-files", "babelignore", "src.js");

it("should load .babelrc", () => {
const filename = fixture("config-files", "babelrc", "src.js");

expect(
loadOptions({
filename,
cwd: path.dirname(filename),
}),
).toEqual({
...getDefaults(),
filename: filename,
cwd: path.dirname(filename),
root: path.dirname(filename),
comments: true,
expect(
loadOptions({ filename, cwd: path.dirname(filename) }),
).toBeNull();
});
});

it("should load .babelrc.js", () => {
const filename = fixture("config-files", "babelrc-js", "src.js");

expect(loadOptions({ filename, cwd: path.dirname(filename) })).toEqual({
...getDefaults(),
filename: filename,
cwd: path.dirname(filename),
root: path.dirname(filename),
comments: true,
});
});
test.each(
pairs(["package.json", ".babelrc", ".babelrc.js", ".babelrc.cjs"]),
)("should throw if both %s and %s are used", async (name1, name2) => {
const { cwd, tmp, config } = await getTemp(
`babel-test-dup-config-${name1}-${name2}`,
);

it("should load package.json#babel", () => {
const filename = fixture("config-files", "pkg", "src.js");
await Promise.all([config(name1), config(name2)]);

expect(loadOptions({ filename, cwd: path.dirname(filename) })).toEqual({
...getDefaults(),
filename: filename,
cwd: path.dirname(filename),
root: path.dirname(filename),
comments: true,
expect(() => loadOptions({ filename: tmp("src.js"), cwd })).toThrow(
/Multiple configuration files found/,
);
});
});

it("should load .babelignore", () => {
const filename = fixture("config-files", "babelignore", "src.js");

expect(loadOptions({ filename, cwd: path.dirname(filename) })).toBeNull();
});

it("should throw if there are both .babelrc and .babelrc.js", () => {
const filename = fixture("config-files", "both-babelrc", "src.js");

expect(() =>
loadOptions({ filename, cwd: path.dirname(filename) }),
).toThrow(/Multiple configuration files found/);
});

it("should throw if there are both .babelrc and package.json", () => {
const filename = fixture("config-files", "pkg-babelrc", "src.js");

expect(() =>
loadOptions({ filename, cwd: path.dirname(filename) }),
).toThrow(/Multiple configuration files found/);
});

it("should throw if there are both .babelrc.js and package.json", () => {
const filename = fixture("config-files", "pkg-babelrc-js", "src.js");

expect(() =>
loadOptions({ filename, cwd: path.dirname(filename) }),
).toThrow(/Multiple configuration files found/);
});

it("should ignore package.json without a 'babel' property", () => {
const filename = fixture("config-files", "pkg-ignored", "src.js");
it("should ignore package.json without a 'babel' property", () => {
const filename = fixture("config-files", "pkg-ignored", "src.js");

expect(loadOptions({ filename, cwd: path.dirname(filename) })).toEqual({
...getDefaults(),
filename: filename,
cwd: path.dirname(filename),
root: path.dirname(filename),
comments: true,
expect(loadOptions({ filename, cwd: path.dirname(filename) })).toEqual({
...getDefaults(),
filename: filename,
cwd: path.dirname(filename),
root: path.dirname(filename),
comments: true,
});
});
});

it("should show helpful errors for .babelrc", () => {
const filename = fixture("config-files", "babelrc-error", "src.js");
test.each`
config | dir | error
${".babelrc"} | ${"babelrc-error"} | ${/Error while parsing config - /}
${".babelrc.js"} | ${"babelrc-js-error"} | ${/Babelrc threw an error/}
${".babelrc.cjs"} | ${"babelrc-cjs-error"} | ${/Babelrc threw an error/}
${"package.json"} | ${"pkg-error"} | ${/Error while parsing JSON - /}
`("should show helpful errors for $config", ({ dir, error }) => {
const filename = fixture("config-files", dir, "src.js");

expect(() =>
loadOptions({ filename, cwd: path.dirname(filename) }),
).toThrow(/Error while parsing config - /);
});

it("should show helpful errors for .babelrc.js", () => {
const filename = fixture("config-files", "babelrc-js-error", "src.js");

expect(() =>
loadOptions({ filename, cwd: path.dirname(filename) }),
).toThrow(/Babelrc threw an error/);
});

it("should show helpful errors for package.json", () => {
const filename = fixture("config-files", "pkg-error", "src.js");

expect(() =>
loadOptions({ filename, cwd: path.dirname(filename) }),
).toThrow(/Error while parsing JSON - /);
expect(() =>
loadOptions({ filename, cwd: path.dirname(filename) }),
).toThrow(error);
});
});

it("should throw when `test` presents but `filename` is not passed", () => {
Expand Down
2 changes: 1 addition & 1 deletion ...files/babel-config-json/babel.config.json → ...es/config/config-files-templates/.babelrc
View file
@@ -1,3 +1,3 @@
{
"comments": true
}
}
0 .../babel-config-js-and-json/babel.config.js → ...onfig/config-files-templates/.babelrc.cjs
View file
File renamed without changes.
0 ...fig-files/babel-config-js/babel.config.js → ...config/config-files-templates/.babelrc.js
View file
File renamed without changes.
2 changes: 1 addition & 1 deletion ...onfig/config-files/babelrc-js/.babelrc.js → ...g/config-files-templates/babel.config.cjs
View file
@@ -1,3 +1,3 @@
module.exports = {
comments: true,
comments: true
};
3 changes: 3 additions & 0 deletions packages/babel-core/test/fixtures/config/config-files-templates/babel.config.js
View file
@@ -0,0 +1,3 @@
module.exports = {
comments: true
};
0 ...abel-config-js-and-json/babel.config.json → .../config-files-templates/babel.config.json
View file
File renamed without changes.
0 ...ures/config/config-files/pkg/package.json → ...onfig/config-files-templates/package.json
View file
File renamed without changes.
3 changes: 3 additions & 0 deletions packages/babel-core/test/fixtures/config/config-files/babelrc-cjs-error/.babelrc.cjs
View file
@@ -0,0 +1,3 @@
module.exports = function() {
throw new Error("Babelrc threw an error");
};
3 changes: 0 additions & 3 deletions packages/babel-core/test/fixtures/config/config-files/babelrc/.babelrc
View file

This file was deleted.

1 change: 0 additions & 1 deletion packages/babel-core/test/fixtures/config/config-files/both-babelrc/.babelrc
View file

This file was deleted.

1 change: 0 additions & 1 deletion packages/babel-core/test/fixtures/config/config-files/both-babelrc/.babelrc.js
View file

This file was deleted.

1 change: 0 additions & 1 deletion packages/babel-core/test/fixtures/config/config-files/pkg-babelrc-js/.babelrc.js
View file

This file was deleted.

3 changes: 0 additions & 3 deletions packages/babel-core/test/fixtures/config/config-files/pkg-babelrc-js/package.json
View file

This file was deleted.

1 change: 0 additions & 1 deletion packages/babel-core/test/fixtures/config/config-files/pkg-babelrc/.babelrc
View file

This file was deleted.

3 changes: 0 additions & 3 deletions packages/babel-core/test/fixtures/config/config-files/pkg-babelrc/package.json
View file

This file was deleted.

0 comments on commit c98dca5

Please sign in to comment.