refactor: remove unused finished proposals json

babel · Jan 7, 2020 · c69c141 · c69c141
1 parent 7e76e07
commit c69c141
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/packages/babel-preset-env/data/corejs3-finished-proposals.json b/packages/babel-preset-env/data/corejs3-finished-proposals.json
diff --git a/packages/babel-preset-env/scripts/build-corejs3-proposals.js b/packages/babel-preset-env/scripts/build-corejs3-proposals.js
@@ -17,7 +17,16 @@ const finishedProposals = shippedProposals.filter(feature => {
   return features.includes(feature.replace("esnext.", "es."));
 });
 
-fs.writeFileSync(
-  path.join(__dirname, "../data/corejs3-finished-proposals.json"),
-  JSON.stringify(finishedProposals, undefined, 2) + "\n"
+const builtInDefinitions = fs.readFileSync(
+  path.join(__dirname, "../src/polyfills/corejs3/built-in-definitions.js"),
+  "utf-8"
 );
+
+for (const feature of finishedProposals) {
+  const standarizedName = feature.replace("esnext.", "es.");
+  if (!builtInDefinitions.includes(standarizedName)) {
+    console.log(
+      `${feature} is now standarized as ${standarizedName}, please add "${standarizedName}" to src/polyfills/corejs3/built-in-definitions`
+    );
+  }
+}
diff --git a/packages/babel-preset-env/src/polyfills/corejs3/usage-plugin.js b/packages/babel-preset-env/src/polyfills/corejs3/usage-plugin.js
@@ -1,7 +1,6 @@
 // @flow
 
 import corejs3Polyfills from "core-js-compat/data";
-import corejs3FinishedProposalsList from "../../../data/corejs3-finished-proposals.json";
 import corejs3ShippedProposalsList from "../../../data/corejs3-shipped-proposals.json";
 import getModulesListForTargetVersion from "core-js-compat/get-modules-list-for-target-version";
 import filterItems from "../../filter-items";
@@ -34,11 +33,7 @@ const NO_DIRECT_POLYFILL_IMPORT = `
   Please remove the direct import of \`core-js\` or use \`useBuiltIns: 'entry'\` instead.`;
 
 const corejs3PolyfillsWithoutProposals = Object.keys(corejs3Polyfills)
-  .filter(
-    name =>
-      !name.startsWith("esnext.") ||
-      (corejs3FinishedProposalsList: string[]).includes(name),
-  )
+  .filter(name => !name.startsWith("esnext."))
   .reduce((memo, key) => {
     memo[key] = corejs3Polyfills[key];
     return memo;