fix: returnType with comments generates incorrect code (#14758)

* fix * review
babel · Jul 14, 2022 · b8f5afd · b8f5afd
1 parent 0df9f62
commit b8f5afd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/packages/babel-generator/src/generators/methods.ts b/packages/babel-generator/src/generators/methods.ts
@@ -11,7 +11,15 @@ export function _params(
   this._parameters(node.params, node);
   this.token(")");
 
-  this.print(node.returnType, node);
+  if (node.returnType) {
+    if (node.type === "ArrowFunctionExpression") {
+      this._noLineTerminator = true;
+      this.print(node.returnType, node);
+      this._noLineTerminator = false;
+    } else {
+      this.print(node.returnType, node);
+    }
+  }
 }
 
 export function _parameters(

diff --git a/packages/babel-generator/test/fixtures/typescript/types-arrow-return-with-comment/input.js b/packages/babel-generator/test/fixtures/typescript/types-arrow-return-with-comment/input.js
@@ -0,0 +1 @@
+export default (): void /* hi! */ => {};
diff --git a/packages/babel-generator/test/fixtures/typescript/types-arrow-return-with-comment/output.js b/packages/babel-generator/test/fixtures/typescript/types-arrow-return-with-comment/output.js
@@ -0,0 +1 @@
+export default ((): void /* hi! */ => {});