Added test file and corrected the visitor

babel · Feb 8, 2020 · b822bd0 · b822bd0
1 parent 5a7c3d8
commit b822bd0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/packages/babel-helper-module-transforms/src/rewrite-this.js b/packages/babel-helper-module-transforms/src/rewrite-this.js
@@ -1,5 +1,3 @@
-import { classMethod } from "@babel/types";
-
 export default function rewriteThis(programPath: NodePath) {
   // Rewrite "this" to be "undefined".
   programPath.traverse(rewriteThisVisitor);
@@ -17,9 +15,13 @@ const rewriteThisVisitor = {
     if (!path.isArrowFunctionExpression()) path.skip();
   },
   ClassProperty(path) {
-    classMethod(path);
     path.skip();
   },
+  ClassMethod(path) {
+    if (path.node.computed) {
+      //requeue the key child of classProperty here
+    }
+  },
   ClassPrivateProperty(path) {
     path.skip();
   },

diff --git a/...in-transform-modules-commonjs/test/fixtures/rewritethis-computed-class-elements/input.mjs b/...in-transform-modules-commonjs/test/fixtures/rewritethis-computed-class-elements/input.mjs
@@ -0,0 +1 @@
+export class C { [this.name] = 42 }
diff --git a/...transform-modules-commonjs/test/fixtures/rewritethis-computed-class-elements/options.json b/...transform-modules-commonjs/test/fixtures/rewritethis-computed-class-elements/options.json
@@ -0,0 +1,7 @@
+{
+  "plugins": [
+    "external-helpers",
+    "transform-modules-commonjs",
+    "@babel/plugin-proposal-class-properties"
+  ]
+}