chore: remove flow check scripts (#14785)

babel · Jul 24, 2022 · acee429 · acee429
1 parent 6af3ba7
commit acee429
Show file tree

Hide file tree

Showing 18 changed files with 13 additions and 562 deletions.
diff --git a/.flowconfig b/.flowconfig
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -171,7 +171,7 @@ jobs:
         with:
           name: babel-artifact
       - name: Lint
-        run: make -j tscheck flowcheck-ci lint-ci
+        run: make -j tscheck lint-ci
 
   test:
     name: Test on Node.js # GitHub will add ${{ matrix.node-version }} to this title
@@ -244,7 +244,7 @@ jobs:
           BABEL_8_BREAKING: true
           STRIP_BABEL_8_FLAG: true
       - name: Lint
-        run: make -j tscheck flowcheck-ci lint-ci
+        run: make -j tscheck lint-ci
         env:
           BABEL_ENV: test
           BABEL_8_BREAKING: true

diff --git a/.gitpod.yml b/.gitpod.yml
@@ -37,4 +37,3 @@ vscode:
   extensions:
     - dbaeumer.vscode-eslint@2.1.5:9Wg0Glx/TwD8ElFBg+FKcQ==
     - esbenp.prettier-vscode@5.0.0:qca7d0cHbKkrkb5rvNlpcg==
-    - flowtype.flow-for-vscode@1.5.0:AwOT6wgHTF43loZQCAUMLA==
diff --git a/Makefile b/Makefile
@@ -74,18 +74,12 @@ build-plugin-transform-runtime-dist:
 watch: build-no-bundle
 	BABEL_ENV=development $(YARN) gulp watch
 
-flowcheck-ci:
-	$(MAKE) flow
-
-code-quality: tscheck flow lint
+code-quality: tscheck lint
 
 tscheck: generate-tsconfig
 	rm -rf dts
 	$(YARN) tsc -b .
 
-flow: build-flow-typings
-	$(YARN) flow check --strip-root
-
 lint-ci: lint check-compat-data-ci
 
 check-compat-data-ci:

diff --git a/babel.config.js b/babel.config.js
@@ -172,6 +172,8 @@ module.exports = function (api) {
       .filter(Boolean)
       .map(normalize),
     presets: [
+      // presets are applied from right to left
+      ["@babel/env", envOpts],
       [
         "@babel/preset-typescript",
         {
@@ -180,8 +182,6 @@ module.exports = function (api) {
           optimizeConstEnums: true,
         },
       ],
-      ["@babel/env", envOpts],
-      ["@babel/preset-flow", { allowDeclareFields: true }],
     ],
     plugins: [
       ["@babel/proposal-object-rest-spread", { useBuiltIns: true }],

diff --git a/eslint/babel-eslint-config-internal/index.js b/eslint/babel-eslint-config-internal/index.js
@@ -3,9 +3,7 @@
 module.exports = {
   parser: "@babel/eslint-parser/experimental-worker",
   extends: "eslint:recommended",
-  plugins: ["flowtype"],
   parserOptions: {
-    ecmaVersion: 2020,
     sourceType: "module",
   },
   globals: {
@@ -15,7 +13,7 @@ module.exports = {
   },
   env: {
     node: true,
-    es2020: true,
+    es2022: true,
     browser: true,
   },
   rules: {
@@ -27,7 +25,5 @@ module.exports = {
     "no-process-exit": "error",
     "no-var": "error",
     "prefer-const": "error",
-    "flowtype/define-flow-type": "warn",
-    "flowtype/use-flow-type": "warn",
   },
 };
diff --git a/eslint/babel-eslint-config-internal/package.json b/eslint/babel-eslint-config-internal/package.json
@@ -10,7 +10,6 @@
     "./package.json": "./package.json"
   },
   "peerDependencies": {
-    "@babel/eslint-parser": "^7.16.0",
-    "eslint-plugin-flowtype": "^8.0.3"
+    "@babel/eslint-parser": "^7.16.0"
   }
 }
diff --git a/eslint/babel-eslint-plugin/src/rules/semi.cjs b/eslint/babel-eslint-plugin/src/rules/semi.cjs
@@ -47,7 +47,7 @@ function isOneLinerBlock(context, node) {
   );
 }
 
-function report(context, node, missing?) {
+function report(context, node, missing) {
   const lastToken = context.getSourceCode().getLastToken(node);
 
   let message,