Skip to content

Commit

Permalink
Throw a TypeError when reassigning a const (#12252)
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolo-ribaudo committed Oct 25, 2020
1 parent b4ae7b7 commit a967910
Show file tree
Hide file tree
Showing 10 changed files with 11 additions and 9 deletions.
2 changes: 1 addition & 1 deletion packages/babel-helpers/src/helpers.js
Expand Up @@ -871,7 +871,7 @@ helpers.taggedTemplateLiteralLoose = helper("7.0.0-beta.0")`

helpers.readOnlyError = helper("7.0.0-beta.0")`
export default function _readOnlyError(name) {
throw new Error("\\"" + name + "\\" is read-only");
throw new TypeError("\\"" + name + "\\" is read-only");
}
`;

Expand Down
@@ -1,4 +1,4 @@
function _readOnlyError(name) { throw new Error("\"" + name + "\" is read-only"); }
function _readOnlyError(name) { throw new TypeError("\"" + name + "\" is read-only"); }

(function () {
var a = "foo";
Expand Down
@@ -1,4 +1,4 @@
function _readOnlyError(name) { throw new Error("\"" + name + "\" is read-only"); }
function _readOnlyError(name) { throw new TypeError("\"" + name + "\" is read-only"); }

var a = 1,
b = 2;
Expand Down
@@ -1,4 +1,4 @@
function _readOnlyError(name) { throw new Error("\"" + name + "\" is read-only"); }
function _readOnlyError(name) { throw new TypeError("\"" + name + "\" is read-only"); }

for (var i = 0; i < 3; i = (_readOnlyError("i"), i + 1)) {
console.log(i);
Expand Down
@@ -1,4 +1,4 @@
function _readOnlyError(name) { throw new Error("\"" + name + "\" is read-only"); }
function _readOnlyError(name) { throw new TypeError("\"" + name + "\" is read-only"); }

var c = 17;
var a = 0;
Expand Down
@@ -1,4 +1,4 @@
function _readOnlyError(name) { throw new Error("\"" + name + "\" is read-only"); }
function _readOnlyError(name) { throw new TypeError("\"" + name + "\" is read-only"); }

var MULTIPLIER = 5;
MULTIPLIER = (_readOnlyError("MULTIPLIER"), "overwrite");
@@ -1,4 +1,4 @@
function _readOnlyError(name) { throw new Error("\"" + name + "\" is read-only"); }
function _readOnlyError(name) { throw new TypeError("\"" + name + "\" is read-only"); }

var MULTIPLIER = 5;

Expand Down
@@ -1,4 +1,4 @@
function _readOnlyError(name) { throw new Error("\"" + name + "\" is read-only"); }
function _readOnlyError(name) { throw new TypeError("\"" + name + "\" is read-only"); }

var a = "str";
_readOnlyError("a"), --a;
@@ -1,4 +1,4 @@
function _readOnlyError(name) { throw new Error("\"" + name + "\" is read-only"); }
function _readOnlyError(name) { throw new TypeError("\"" + name + "\" is read-only"); }

var foo = 1;
_readOnlyError("foo"), foo++;
@@ -0,0 +1,2 @@
const a = 1;
expect(() => { a = 2 }).toThrow(TypeError);

0 comments on commit a967910

Please sign in to comment.