loosen defineType typings

The AST typings are generated from defineType calls, so defineType should accept a string as type.
babel · Jun 20, 2022 · a920dc3 · a920dc3
1 parent 626983b
commit a920dc3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/babel-types/src/definitions/misc.ts b/packages/babel-types/src/definitions/misc.ts
@@ -9,7 +9,6 @@ import { PLACEHOLDERS } from "./placeholders";
 const defineType = defineAliasedType("Miscellaneous");
 
 if (!process.env.BABEL_8_BREAKING) {
-  // @ts-ignore Babel 7 AST
   defineType("Noop", {
     visitor: [],
   });

diff --git a/packages/babel-types/src/definitions/utils.ts b/packages/babel-types/src/definitions/utils.ts
@@ -278,7 +278,7 @@ const validFieldKeys = ["default", "optional", "validate"];
 
 // Wraps defineType to ensure these aliases are included.
 export function defineAliasedType(...aliases: string[]) {
-  return (type: NodeTypes, opts: DefineTypeOpts = {}) => {
+  return (type: string, opts: DefineTypeOpts = {}) => {
     let defined = opts.aliases;
     if (!defined) {
       if (opts.inherits) defined = store[opts.inherits].aliases?.slice();
@@ -291,7 +291,7 @@ export function defineAliasedType(...aliases: string[]) {
   };
 }
 
-export default function defineType(type: NodeTypes, opts: DefineTypeOpts = {}) {
+export default function defineType(type: string, opts: DefineTypeOpts = {}) {
   const inherits = (opts.inherits && store[opts.inherits]) || {};
 
   let fields = opts.fields;
@@ -373,4 +373,4 @@ export default function defineType(type: NodeTypes, opts: DefineTypeOpts = {}) {
   store[type] = opts;
 }
 
-const store = {} as Record<NodeTypes, DefineTypeOpts>;
+const store = {} as Record<string, DefineTypeOpts>;