fix: check await when parsing AsyncArrowBindingIdentifier (#10953)

babel · Jan 3, 2020 · a283537 · a283537
1 parent 467667a
commit a283537
Show file tree

Hide file tree

Showing 3 changed files with 118 additions and 0 deletions.
diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js
@@ -960,8 +960,18 @@ export default class ExpressionParser extends LValParser {
           this.match(tt.name) &&
           !this.canInsertSemicolon()
         ) {
+          const oldMaybeInArrowParameters = this.state.maybeInArrowParameters;
+          const oldYieldPos = this.state.yieldPos;
+          const oldAwaitPos = this.state.awaitPos;
+          this.state.maybeInArrowParameters = true;
+          this.state.yieldPos = -1;
+          this.state.awaitPos = -1;
           const params = [this.parseIdentifier()];
           this.expect(tt.arrow);
+          this.checkYieldAwaitInDefaultParams();
+          this.state.maybeInArrowParameters = oldMaybeInArrowParameters;
+          this.state.yieldPos = oldYieldPos;
+          this.state.awaitPos = oldAwaitPos;
           // let foo = async bar => {};
           this.parseArrowExpression(node, params, true);
           return node;

diff --git a/...ser/test/fixtures/es2017/async-functions/async-await-as-arrow-binding-identifier/input.js b/...ser/test/fixtures/es2017/async-functions/async-await-as-arrow-binding-identifier/input.js
@@ -0,0 +1 @@
+async await => {}
diff --git a/.../test/fixtures/es2017/async-functions/async-await-as-arrow-binding-identifier/output.json b/.../test/fixtures/es2017/async-functions/async-await-as-arrow-binding-identifier/output.json
@@ -0,0 +1,107 @@
+{
+  "type": "File",
+  "start": 0,
+  "end": 17,
+  "loc": {
+    "start": {
+      "line": 1,
+      "column": 0
+    },
+    "end": {
+      "line": 1,
+      "column": 17
+    }
+  },
+  "errors": [
+    "SyntaxError: Await cannot be used as name inside an async function (1:6)"
+  ],
+  "program": {
+    "type": "Program",
+    "start": 0,
+    "end": 17,
+    "loc": {
+      "start": {
+        "line": 1,
+        "column": 0
+      },
+      "end": {
+        "line": 1,
+        "column": 17
+      }
+    },
+    "sourceType": "script",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExpressionStatement",
+        "start": 0,
+        "end": 17,
+        "loc": {
+          "start": {
+            "line": 1,
+            "column": 0
+          },
+          "end": {
+            "line": 1,
+            "column": 17
+          }
+        },
+        "expression": {
+          "type": "ArrowFunctionExpression",
+          "start": 0,
+          "end": 17,
+          "loc": {
+            "start": {
+              "line": 1,
+              "column": 0
+            },
+            "end": {
+              "line": 1,
+              "column": 17
+            }
+          },
+          "id": null,
+          "generator": false,
+          "async": true,
+          "params": [
+            {
+              "type": "Identifier",
+              "start": 6,
+              "end": 11,
+              "loc": {
+                "start": {
+                  "line": 1,
+                  "column": 6
+                },
+                "end": {
+                  "line": 1,
+                  "column": 11
+                },
+                "identifierName": "await"
+              },
+              "name": "await"
+            }
+          ],
+          "body": {
+            "type": "BlockStatement",
+            "start": 15,
+            "end": 17,
+            "loc": {
+              "start": {
+                "line": 1,
+                "column": 15
+              },
+              "end": {
+                "line": 1,
+                "column": 17
+              }
+            },
+            "body": [],
+            "directives": []
+          }
+        }
+      }
+    ],
+    "directives": []
+  }
+}