[ts] Make ImportDeclaration always have importKind (#12170)

babel · Oct 29, 2020 · 963537d · 963537d
1 parent ff6c379
commit 963537d
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/packages/babel-parser/src/plugins/typescript/index.js b/packages/babel-parser/src/plugins/typescript/index.js
@@ -2007,11 +2007,13 @@ export default (superClass: Class<Parser>): Class<Parser> =>
         ) {
           node.importKind = "type";
           this.next();
-        } else {
-          node.importKind = "value";
         }
       }
 
+      if (!node.importKind) {
+        node.importKind = "value";
+      }
+
       const importNode = super.parseImport(node);
       /*:: invariant(importNode.type !== "TSImportEqualsDeclaration") */
 

diff --git a/packages/babel-parser/test/fixtures/typescript/import/import-side-effects/input.ts b/packages/babel-parser/test/fixtures/typescript/import/import-side-effects/input.ts
@@ -0,0 +1 @@
+import "foo";
diff --git a/packages/babel-parser/test/fixtures/typescript/import/import-side-effects/output.json b/packages/babel-parser/test/fixtures/typescript/import/import-side-effects/output.json
@@ -0,0 +1,28 @@
+{
+  "type": "File",
+  "start":0,"end":13,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":13}},
+  "program": {
+    "type": "Program",
+    "start":0,"end":13,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":13}},
+    "sourceType": "module",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ImportDeclaration",
+        "start":0,"end":13,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":13}},
+        "importKind": "value",
+        "specifiers": [],
+        "source": {
+          "type": "StringLiteral",
+          "start":7,"end":12,"loc":{"start":{"line":1,"column":7},"end":{"line":1,"column":12}},
+          "extra": {
+            "rawValue": "foo",
+            "raw": "\"foo\""
+          },
+          "value": "foo"
+        }
+      }
+    ],
+    "directives": []
+  }
+}