Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ts] Allow modifiers as names of methods with type parameters (#12356)
- Loading branch information
1 parent
e8457ea
commit 94d1160
Showing
12 changed files
with
668 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
...ages/babel-parser/test/fixtures/typescript/class/generator-method-with-modifiers/input.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
class C { | ||
private *a() {} | ||
public *b() {} | ||
static *c() {} | ||
abstract *d() {} | ||
readonly *e() {} | ||
declare *f() {} | ||
protected *g() {} | ||
} |
189 changes: 189 additions & 0 deletions
189
...s/babel-parser/test/fixtures/typescript/class/generator-method-with-modifiers/output.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,189 @@ | ||
{ | ||
"type": "File", | ||
"start":0,"end":139,"loc":{"start":{"line":1,"column":0},"end":{"line":9,"column":1}}, | ||
"program": { | ||
"type": "Program", | ||
"start":0,"end":139,"loc":{"start":{"line":1,"column":0},"end":{"line":9,"column":1}}, | ||
"sourceType": "module", | ||
"interpreter": null, | ||
"body": [ | ||
{ | ||
"type": "ClassDeclaration", | ||
"start":0,"end":139,"loc":{"start":{"line":1,"column":0},"end":{"line":9,"column":1}}, | ||
"id": { | ||
"type": "Identifier", | ||
"start":6,"end":7,"loc":{"start":{"line":1,"column":6},"end":{"line":1,"column":7},"identifierName":"C"}, | ||
"name": "C" | ||
}, | ||
"superClass": null, | ||
"body": { | ||
"type": "ClassBody", | ||
"start":8,"end":139,"loc":{"start":{"line":1,"column":8},"end":{"line":9,"column":1}}, | ||
"body": [ | ||
{ | ||
"type": "ClassMethod", | ||
"start":12,"end":27,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":17}}, | ||
"accessibility": "private", | ||
"static": false, | ||
"kind": "method", | ||
"key": { | ||
"type": "Identifier", | ||
"start":21,"end":22,"loc":{"start":{"line":2,"column":11},"end":{"line":2,"column":12},"identifierName":"a"}, | ||
"name": "a" | ||
}, | ||
"computed": false, | ||
"id": null, | ||
"generator": true, | ||
"async": false, | ||
"params": [], | ||
"body": { | ||
"type": "BlockStatement", | ||
"start":25,"end":27,"loc":{"start":{"line":2,"column":15},"end":{"line":2,"column":17}}, | ||
"body": [], | ||
"directives": [] | ||
} | ||
}, | ||
{ | ||
"type": "ClassMethod", | ||
"start":30,"end":44,"loc":{"start":{"line":3,"column":2},"end":{"line":3,"column":16}}, | ||
"accessibility": "public", | ||
"static": false, | ||
"kind": "method", | ||
"key": { | ||
"type": "Identifier", | ||
"start":38,"end":39,"loc":{"start":{"line":3,"column":10},"end":{"line":3,"column":11},"identifierName":"b"}, | ||
"name": "b" | ||
}, | ||
"computed": false, | ||
"id": null, | ||
"generator": true, | ||
"async": false, | ||
"params": [], | ||
"body": { | ||
"type": "BlockStatement", | ||
"start":42,"end":44,"loc":{"start":{"line":3,"column":14},"end":{"line":3,"column":16}}, | ||
"body": [], | ||
"directives": [] | ||
} | ||
}, | ||
{ | ||
"type": "ClassMethod", | ||
"start":47,"end":61,"loc":{"start":{"line":4,"column":2},"end":{"line":4,"column":16}}, | ||
"static": true, | ||
"kind": "method", | ||
"key": { | ||
"type": "Identifier", | ||
"start":55,"end":56,"loc":{"start":{"line":4,"column":10},"end":{"line":4,"column":11},"identifierName":"c"}, | ||
"name": "c" | ||
}, | ||
"computed": false, | ||
"id": null, | ||
"generator": true, | ||
"async": false, | ||
"params": [], | ||
"body": { | ||
"type": "BlockStatement", | ||
"start":59,"end":61,"loc":{"start":{"line":4,"column":14},"end":{"line":4,"column":16}}, | ||
"body": [], | ||
"directives": [] | ||
} | ||
}, | ||
{ | ||
"type": "ClassMethod", | ||
"start":64,"end":80,"loc":{"start":{"line":5,"column":2},"end":{"line":5,"column":18}}, | ||
"abstract": true, | ||
"static": false, | ||
"kind": "method", | ||
"key": { | ||
"type": "Identifier", | ||
"start":74,"end":75,"loc":{"start":{"line":5,"column":12},"end":{"line":5,"column":13},"identifierName":"d"}, | ||
"name": "d" | ||
}, | ||
"computed": false, | ||
"id": null, | ||
"generator": true, | ||
"async": false, | ||
"params": [], | ||
"body": { | ||
"type": "BlockStatement", | ||
"start":78,"end":80,"loc":{"start":{"line":5,"column":16},"end":{"line":5,"column":18}}, | ||
"body": [], | ||
"directives": [] | ||
} | ||
}, | ||
{ | ||
"type": "ClassMethod", | ||
"start":83,"end":99,"loc":{"start":{"line":6,"column":2},"end":{"line":6,"column":18}}, | ||
"readonly": true, | ||
"static": false, | ||
"kind": "method", | ||
"key": { | ||
"type": "Identifier", | ||
"start":93,"end":94,"loc":{"start":{"line":6,"column":12},"end":{"line":6,"column":13},"identifierName":"e"}, | ||
"name": "e" | ||
}, | ||
"computed": false, | ||
"id": null, | ||
"generator": true, | ||
"async": false, | ||
"params": [], | ||
"body": { | ||
"type": "BlockStatement", | ||
"start":97,"end":99,"loc":{"start":{"line":6,"column":16},"end":{"line":6,"column":18}}, | ||
"body": [], | ||
"directives": [] | ||
} | ||
}, | ||
{ | ||
"type": "ClassMethod", | ||
"start":102,"end":117,"loc":{"start":{"line":7,"column":2},"end":{"line":7,"column":17}}, | ||
"declare": true, | ||
"static": false, | ||
"kind": "method", | ||
"key": { | ||
"type": "Identifier", | ||
"start":111,"end":112,"loc":{"start":{"line":7,"column":11},"end":{"line":7,"column":12},"identifierName":"f"}, | ||
"name": "f" | ||
}, | ||
"computed": false, | ||
"id": null, | ||
"generator": true, | ||
"async": false, | ||
"params": [], | ||
"body": { | ||
"type": "BlockStatement", | ||
"start":115,"end":117,"loc":{"start":{"line":7,"column":15},"end":{"line":7,"column":17}}, | ||
"body": [], | ||
"directives": [] | ||
} | ||
}, | ||
{ | ||
"type": "ClassMethod", | ||
"start":120,"end":137,"loc":{"start":{"line":8,"column":2},"end":{"line":8,"column":19}}, | ||
"accessibility": "protected", | ||
"static": false, | ||
"kind": "method", | ||
"key": { | ||
"type": "Identifier", | ||
"start":131,"end":132,"loc":{"start":{"line":8,"column":13},"end":{"line":8,"column":14},"identifierName":"g"}, | ||
"name": "g" | ||
}, | ||
"computed": false, | ||
"id": null, | ||
"generator": true, | ||
"async": false, | ||
"params": [], | ||
"body": { | ||
"type": "BlockStatement", | ||
"start":135,"end":137,"loc":{"start":{"line":8,"column":17},"end":{"line":8,"column":19}}, | ||
"body": [], | ||
"directives": [] | ||
} | ||
} | ||
] | ||
} | ||
} | ||
], | ||
"directives": [] | ||
} | ||
} |
9 changes: 9 additions & 0 deletions
9
...-parser/test/fixtures/typescript/class/method-modifier-name-with-type-parameters/input.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
class C { | ||
declare<T>() {} | ||
readonly<T>() {} | ||
abstract<T>() {} | ||
static<T>() {} | ||
private<T>() {} | ||
public<T>() {} | ||
protected<T>() {} | ||
} |
Oops, something went wrong.