Partial Application Plugin

babel · Feb 20, 2019 · 9196d67 · 9196d67
1 parent 487d64e
commit 9196d67
Show file tree

Hide file tree

Showing 11 changed files with 15 additions and 24 deletions.
diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js
@@ -836,9 +836,6 @@ export default class ExpressionParser extends LValParser {
         }
         return this.finishNode(node, "Super");
 
-      case tt.question:
-        node = this.startNode();
-        this.raise(node.start, "Partial Application syntax is not allowed");
       case tt._import:
         if (this.lookahead().type === tt.dot) {
           return this.parseImportMetaProperty();
@@ -1350,12 +1347,6 @@ export default class ExpressionParser extends LValParser {
   parseNewArguments(node: N.NewExpression): void {
     if (this.eat(tt.parenL)) {
       const args = this.parseExprList(tt.parenR);
-      if (this.hasPartial(args)) {
-        this.raise(
-          this.state.start,
-          "Partial Application syntax is not allowed with 'new' keyword",
-        );
-      }
       this.toReferencedList(args);
       // $FlowFixMe (parseExprList should be all non-null in this case)
       node.arguments = args;

diff --git a/packages/babel-parser/test/fixtures/experimental/partial-application/call-expr/output.json b/packages/babel-parser/test/fixtures/experimental/partial-application/call-expr/output.json
@@ -76,7 +76,7 @@
           },
           "arguments": [
             {
-              "type": "Partial",
+              "type": "ArgumentPlaceholder",
               "start": 4,
               "end": 5,
               "loc": {

diff --git a/...l-parser/test/fixtures/experimental/partial-application/call-on-SuperProperty/output.json b/...l-parser/test/fixtures/experimental/partial-application/call-on-SuperProperty/output.json
@@ -272,7 +272,7 @@
                             },
                             "arguments": [
                               {
-                                "type": "Partial",
+                                "type": "ArgumentPlaceholder",
                                 "start": 66,
                                 "end": 67,
                                 "loc": {

diff --git a/packages/babel-parser/test/fixtures/experimental/partial-application/for-any-arg/output.json b/packages/babel-parser/test/fixtures/experimental/partial-application/for-any-arg/output.json
@@ -76,7 +76,7 @@
           },
           "arguments": [
             {
-              "type": "Partial",
+              "type": "ArgumentPlaceholder",
               "start": 4,
               "end": 5,
               "loc": {
@@ -108,7 +108,7 @@
               "name": "x"
             },
             {
-              "type": "Partial",
+              "type": "ArgumentPlaceholder",
               "start": 8,
               "end": 9,
               "loc": {
@@ -205,7 +205,7 @@
           },
           "arguments": [
             {
-              "type": "Partial",
+              "type": "ArgumentPlaceholder",
               "start": 20,
               "end": 21,
               "loc": {
@@ -237,7 +237,7 @@
               "name": "x"
             },
             {
-              "type": "Partial",
+              "type": "ArgumentPlaceholder",
               "start": 26,
               "end": 27,
               "loc": {

diff --git a/packages/babel-parser/test/fixtures/experimental/partial-application/from-left/output.json b/packages/babel-parser/test/fixtures/experimental/partial-application/from-left/output.json
@@ -93,7 +93,7 @@
               "name": "x"
             },
             {
-              "type": "Partial",
+              "type": "ArgumentPlaceholder",
               "start": 6,
               "end": 7,
               "loc": {
@@ -207,7 +207,7 @@
               "name": "x"
             },
             {
-              "type": "Partial",
+              "type": "ArgumentPlaceholder",
               "start": 20,
               "end": 21,
               "loc": {

diff --git a/packages/babel-parser/test/fixtures/experimental/partial-application/from-right/output.json b/packages/babel-parser/test/fixtures/experimental/partial-application/from-right/output.json
@@ -76,7 +76,7 @@
           },
           "arguments": [
             {
-              "type": "Partial",
+              "type": "ArgumentPlaceholder",
               "start": 4,
               "end": 5,
               "loc": {
@@ -190,7 +190,7 @@
           },
           "arguments": [
             {
-              "type": "Partial",
+              "type": "ArgumentPlaceholder",
               "start": 18,
               "end": 19,
               "loc": {

diff --git a/packages/babel-parser/test/fixtures/experimental/partial-application/in-SuperCall/input.js b/packages/babel-parser/test/fixtures/experimental/partial-application/in-SuperCall/input.js
@@ -1,6 +1,6 @@
 class foo{
   constructor(x){
-    super(XXX, 1, ?, ?);
+    super(x, 1, ?, ?);
     this.x = x;
   }
 }
diff --git a/...ges/babel-parser/test/fixtures/experimental/partial-application/in-SuperCall/options.json b/...ges/babel-parser/test/fixtures/experimental/partial-application/in-SuperCall/options.json
@@ -1,4 +1,4 @@
 {
   "plugins": ["partialApplication"],
-  "throws": "Partial Application syntax is not allowed (3:18)"
+  "throws": "Unexpected argument placeholder (3:16)"
 }
diff --git a/packages/babel-parser/test/fixtures/experimental/partial-application/in-new/options.json b/packages/babel-parser/test/fixtures/experimental/partial-application/in-new/options.json
@@ -1,4 +1,4 @@
 {
   "plugins": ["partialApplication"],
-  "throws": "Partial Application syntax is not allowed (1:11)"
+  "throws": "Unexpected argument placeholder (1:11)"
 }
diff --git a/...xtures/experimental/partial-application/top-level-argument-binary-expression/options.json b/...xtures/experimental/partial-application/top-level-argument-binary-expression/options.json
@@ -1,4 +1,4 @@
 {
   "plugins": ["partialApplication"],
-  "throws": "Partial Application syntax is not allowed (1:0)"
+  "throws": "Unexpected token (1:0)"
 }
diff --git a/packages/babel-plugin-syntax-partial-application/package.json b/packages/babel-plugin-syntax-partial-application/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@babel/plugin-syntax-partial-application",
   "version": "7.2.0",
-  "description": "Allow parsing of optional properties",
+  "description": "Allow parsing of partial application syntax",
   "repository": "https://github.com/babel/babel/tree/master/packages/babel-plugin-syntax-partial-application",
   "license": "MIT",
   "publishConfig": {