feat: support bigInt in numeric-separator transform (#12240)

babel · Oct 22, 2020 · 8b579a2 · 8b579a2
1 parent d6816f0
commit 8b579a2
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 6 deletions.
diff --git a/packages/babel-plugin-proposal-numeric-separator/src/index.js b/packages/babel-plugin-proposal-numeric-separator/src/index.js
@@ -1,6 +1,19 @@
 import { declare } from "@babel/helper-plugin-utils";
 import syntaxNumericSeparator from "@babel/plugin-syntax-numeric-separator";
 
+/**
+ * Given a bigIntLiteral or NumericLiteral, remove numeric
+ * separator `_` from its raw representation
+ *
+ * @param {NodePath<BigIntLiteral | NumericLiteral>} { node }: A Babel AST node path
+ */
+function remover({ node }: NodePath<BigIntLiteral | NumericLiteral>) {
+  const { extra } = node;
+  if (extra && extra.raw.includes("_")) {
+    extra.raw = extra.raw.replace(/_/g, "");
+  }
+}
+
 export default declare(api => {
   api.assertVersion(7);
 
@@ -9,12 +22,8 @@ export default declare(api => {
     inherits: syntaxNumericSeparator,
 
     visitor: {
-      NumericLiteral({ node }) {
-        const { extra } = node;
-        if (extra && /_/.test(extra.raw)) {
-          extra.raw = extra.raw.replace(/_/g, "");
-        }
-      },
+      NumericLiteral: remover,
+      BigIntLiteral: remover,
     },
   };
 });
diff --git a/packages/babel-plugin-proposal-numeric-separator/test/fixtures/removal/bigint-exec/exec.js b/packages/babel-plugin-proposal-numeric-separator/test/fixtures/removal/bigint-exec/exec.js
@@ -0,0 +1 @@
+expect(9_007_199_254_740_993n).toBe(9007199254740993n);
diff --git a/...es/babel-plugin-proposal-numeric-separator/test/fixtures/removal/bigint-exec/options.json b/...es/babel-plugin-proposal-numeric-separator/test/fixtures/removal/bigint-exec/options.json
@@ -0,0 +1,4 @@
+{
+  "plugins": ["proposal-numeric-separator"],
+  "minNodeVersion": "10.4.0"
+}
diff --git a/packages/babel-plugin-proposal-numeric-separator/test/fixtures/removal/bigint/input.js b/packages/babel-plugin-proposal-numeric-separator/test/fixtures/removal/bigint/input.js
@@ -0,0 +1 @@
+9_007_199_254_740_993n;
diff --git a/packages/babel-plugin-proposal-numeric-separator/test/fixtures/removal/bigint/output.js b/packages/babel-plugin-proposal-numeric-separator/test/fixtures/removal/bigint/output.js
@@ -0,0 +1 @@
+9007199254740993n;
diff --git a/...c-separator/test/fixtures/removal/exec.js → ...tor/test/fixtures/removal/numeric/exec.js b/...c-separator/test/fixtures/removal/exec.js → ...tor/test/fixtures/removal/numeric/exec.js