Use babel-check-duplicated-nodes (#8768)

babel · Sep 25, 2018 · 889cdb8 · 889cdb8
1 parent af694eb
commit 889cdb8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 47 deletions.
diff --git a/packages/babel-helper-transform-fixture-test-runner/package.json b/packages/babel-helper-transform-fixture-test-runner/package.json
@@ -15,6 +15,7 @@
     "@babel/core": "^7.1.0",
     "@babel/helper-fixtures": "^7.0.0",
     "@babel/polyfill": "^7.0.0",
+    "babel-check-duplicated-nodes": "^1.0.0",
     "jest": "^22.4.2",
     "jest-diff": "^22.4.0",
     "lodash": "^4.17.10",

diff --git a/packages/babel-helper-transform-fixture-test-runner/src/index.js b/packages/babel-helper-transform-fixture-test-runner/src/index.js
@@ -15,6 +15,7 @@ import assert from "assert";
 import fs from "fs";
 import path from "path";
 import vm from "vm";
+import checkDuplicatedNodes from "babel-check-duplicated-nodes";
 
 import diff from "jest-diff";
 
@@ -129,51 +130,6 @@ function wrapPackagesArray(type, names, optionsDir) {
   });
 }
 
-function checkDuplicatedNodes(ast) {
-  const nodes = new WeakSet();
-  const parents = new WeakMap();
-
-  const setParent = (child, parent) => {
-    if (typeof child === "object" && child !== null) {
-      let p = parents.get(child);
-      if (!p) {
-        p = [];
-        parents.set(child, p);
-      }
-      p.unshift(parent);
-    }
-  };
-  const registerChildren = node => {
-    for (const key in node) {
-      if (Array.isArray(node[key])) {
-        node[key].forEach(child => setParent(child, node));
-      } else {
-        setParent(node[key], node);
-      }
-    }
-  };
-
-  const hidePrivateProperties = (key, val) => {
-    // Hides properties like _shadowedFunctionLiteral,
-    // which makes the AST circular
-    if (key[0] === "_") return "[Private]";
-    return val;
-  };
-
-  babel.types.traverseFast(ast, node => {
-    registerChildren(node);
-    if (nodes.has(node)) {
-      throw new Error(
-        "Do not reuse nodes. Use `t.cloneNode` to copy them.\n" +
-          JSON.stringify(node, hidePrivateProperties, 2) +
-          "\nParent:\n" +
-          JSON.stringify(parents.get(node), hidePrivateProperties, 2),
-      );
-    }
-    nodes.add(node);
-  });
-}
-
 function run(task) {
   const actual = task.actual;
   const expected = task.expect;
@@ -222,7 +178,7 @@ function run(task) {
   if (execCode) {
     const execOpts = getOpts(exec);
     result = babel.transform(execCode, execOpts);
-    checkDuplicatedNodes(result.ast);
+    checkDuplicatedNodes(babel, result.ast);
     execCode = result.code;
 
     try {
@@ -244,7 +200,7 @@ function run(task) {
       "<CWD>",
     );
 
-    checkDuplicatedNodes(result.ast);
+    checkDuplicatedNodes(babel, result.ast);
     if (
       !expected.code &&
       expectedCode &&