Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Treat break inside block inside loop (#8914)
- Loading branch information
1 parent
9d0dced
commit 84e7884
Showing
5 changed files
with
200 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
packages/babel-plugin-transform-block-scoping/test/fixtures/exec/switch-labeled-break.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// it shouldn't break on a case-break statement | ||
var i; | ||
the_loop: for (i = 0; i < 10; i++) { | ||
switch (i) { | ||
case 3: { | ||
break the_loop; | ||
} | ||
} | ||
|
||
const z = 3; // to force the plugin to convert to loop function call | ||
() => z; | ||
} | ||
|
||
expect(i).toBe(3); |
51 changes: 51 additions & 0 deletions
51
...gin-transform-block-scoping/test/fixtures/general/block-inside-switch-inside-loop/exec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// it shouldn't break on a case-break statement | ||
var i; | ||
for (i = 0; i < 10; i++) { | ||
switch (i) { | ||
case 1: { | ||
break; | ||
} | ||
} | ||
|
||
const z = 3; // to force the plugin to convert to loop function call | ||
() => z; | ||
} | ||
|
||
expect(i).toBe(10); | ||
|
||
// it should continue on continue statements within switch | ||
var j = 0; | ||
for (i = 0; i < 10; i++) { | ||
switch (i) { | ||
case 0: { | ||
continue; | ||
} | ||
} | ||
j++; | ||
|
||
const z = 3; | ||
() => z; | ||
} | ||
|
||
expect(j).toBe(9); | ||
|
||
// it should work with loops nested within switch | ||
j = 0; | ||
for (i = 0; i < 10; i++) { | ||
switch (i) { | ||
case 0: { | ||
for (var k = 0; k < 10; k++) { | ||
const z = 3; | ||
() => z; | ||
j++; | ||
break; | ||
} | ||
break; | ||
} | ||
} | ||
|
||
const z = 3; | ||
() => z; | ||
} | ||
|
||
expect(j).toBe(1); |
48 changes: 48 additions & 0 deletions
48
...in-transform-block-scoping/test/fixtures/general/block-inside-switch-inside-loop/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// it shouldn't break on a case-break statement | ||
var i; | ||
for (i = 0; i < 10; i++) { | ||
switch (i) { | ||
case 1: | ||
break; | ||
} | ||
|
||
const z = 3; // to force the plugin to convert to loop function call | ||
() => z; | ||
} | ||
|
||
expect(i).toBe(10); | ||
|
||
// it should continue on continue statements within switch | ||
var j = 0; | ||
for (i = 0; i < 10; i++) { | ||
switch (i) { | ||
case 0: | ||
continue; | ||
} | ||
j++; | ||
|
||
const z = 3; | ||
() => z; | ||
} | ||
|
||
expect(j).toBe(9); | ||
|
||
// it should work with loops nested within switch | ||
j = 0; | ||
for (i = 0; i < 10; i++) { | ||
switch (i) { | ||
case 0: | ||
for (var k = 0; k < 10; k++) { | ||
const z = 3; | ||
() => z; | ||
j++; | ||
break; | ||
} | ||
break; | ||
} | ||
|
||
const z = 3; | ||
() => z; | ||
} | ||
|
||
expect(j).toBe(1); |
85 changes: 85 additions & 0 deletions
85
...n-transform-block-scoping/test/fixtures/general/block-inside-switch-inside-loop/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
// it shouldn't break on a case-break statement | ||
var i; | ||
|
||
var _loop = function () { | ||
switch (i) { | ||
case 1: | ||
break; | ||
} | ||
|
||
var z = 3; // to force the plugin to convert to loop function call | ||
|
||
(function () { | ||
return z; | ||
}); | ||
}; | ||
|
||
for (i = 0; i < 10; i++) { | ||
_loop(); | ||
} | ||
|
||
expect(i).toBe(10); // it should continue on continue statements within switch | ||
|
||
var j = 0; | ||
|
||
var _loop2 = function () { | ||
switch (i) { | ||
case 0: | ||
return "continue"; | ||
} | ||
|
||
j++; | ||
var z = 3; | ||
|
||
(function () { | ||
return z; | ||
}); | ||
}; | ||
|
||
for (i = 0; i < 10; i++) { | ||
var _ret = _loop2(); | ||
|
||
if (_ret === "continue") continue; | ||
} | ||
|
||
expect(j).toBe(9); // it should work with loops nested within switch | ||
|
||
j = 0; | ||
|
||
var _loop3 = function () { | ||
switch (i) { | ||
case 0: | ||
var _loop4 = function () { | ||
var z = 3; | ||
|
||
(function () { | ||
return z; | ||
}); | ||
|
||
j++; | ||
return "break"; | ||
}; | ||
|
||
for (k = 0; k < 10; k++) { | ||
var _ret2 = _loop4(); | ||
|
||
if (_ret2 === "break") break; | ||
} | ||
|
||
break; | ||
} | ||
|
||
var z = 3; | ||
|
||
(function () { | ||
return z; | ||
}); | ||
}; | ||
|
||
for (i = 0; i < 10; i++) { | ||
var k; | ||
|
||
_loop3(); | ||
} | ||
|
||
expect(j).toBe(1); |