Apply suggestions from code review

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
babel · Feb 9, 2023 · 7ddd8b0 · 7ddd8b0
1 parent 9faf1c5
commit 7ddd8b0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/babel-helper-create-regexp-features-plugin/package.json b/packages/babel-helper-create-regexp-features-plugin/package.json
@@ -19,7 +19,7 @@
   ],
   "dependencies": {
     "@babel/helper-annotate-as-pure": "workspace:^",
-    "regexpu-core": "https://github.com/liuxingbaoyu/regexpu-core#head=modifiers"
+    "regexpu-core": "^5.3.0"
   },
   "peerDependencies": {
     "@babel/core": "^7.0.0"

diff --git a/packages/babel-helper-create-regexp-features-plugin/src/util.ts b/packages/babel-helper-create-regexp-features-plugin/src/util.ts
@@ -72,7 +72,7 @@ export function canSkipRegexpu(
     return false;
   }
 
-  if (options.modifiers === "transform" && /\(\?.{1,10}:/.test(pattern)) {
+  if (options.modifiers === "transform" && /\(\?[\w-]+:/.test(pattern)) {
     return false;
   }
 

diff --git a/packages/babel-plugin-proposal-regexp-modifiers/package.json b/packages/babel-plugin-proposal-regexp-modifiers/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@babel/plugin-proposal-regexp-modifiers",
   "version": "7.19.1",
-  "description": "TODO",
+  "description": "Compile inline regular expression modifiers",
   "homepage": "https://babel.dev/docs/en/next/babel-plugin-proposal-regexp-modifiers",
   "license": "MIT",
   "publishConfig": {