Respect the jsescOption.minimal generator option (#12755)

babel · Feb 4, 2021 · 77d46bc · 77d46bc
1 parent a0e3ef2
commit 77d46bc
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/packages/babel-generator/src/index.ts b/packages/babel-generator/src/index.ts
@@ -58,15 +58,14 @@ function normalizeOptions(code, opts): Format {
     jsescOption: {
       quotes: "double",
       wrap: true,
-      minimal: true,
+      minimal: process.env.BABEL_8_BREAKING ? true : false,
       ...opts.jsescOption,
     },
     recordAndTupleSyntaxType: opts.recordAndTupleSyntaxType,
   };
 
   if (!process.env.BABEL_8_BREAKING) {
     format.jsonCompatibleStrings = opts.jsonCompatibleStrings;
-    delete format.jsescOption.minimal;
   }
 
   if (format.minified) {

diff --git a/packages/babel-generator/test/index.js b/packages/babel-generator/test/index.js
@@ -700,6 +700,30 @@ describe("programmatic generation", function () {
       expect(output).toBe("export default (class {});");
     });
   });
+
+  describe("jsescOption.minimal", () => {
+    const string = t.stringLiteral("\u8868\u683C_\u526F\u672C");
+
+    it("true", () => {
+      const output = generate(string, { jsescOption: { minimal: true } }).code;
+      expect(output).toBe(`"表格_副本"`);
+    });
+
+    it("false", () => {
+      const output = generate(string, { jsescOption: { minimal: false } }).code;
+      expect(output).toBe(`"\\u8868\\u683C_\\u526F\\u672C"`);
+    });
+
+    it("default", () => {
+      const output = generate(string).code;
+
+      if (process.env.BABEL_8_BREAKING) {
+        expect(output).toBe(`"表格_副本"`);
+      } else {
+        expect(output).toBe(`"\\u8868\\u683C_\\u526F\\u672C"`);
+      }
+    });
+  });
 });
 
 describe("CodeGenerator", function () {