babel-plugin-transform-spread add missing argument in build calls (#1…

…3459) * babel-plugin-transform-spread add missing argument in build calls * update tests for babel 8 test
babel · Jun 14, 2021 · 66cbd60 · 66cbd60
1 parent 950d351
commit 66cbd60
Show file tree

Hide file tree

Showing 13 changed files with 28 additions and 2 deletions.
diff --git a/packages/babel-plugin-transform-spread/src/index.js b/packages/babel-plugin-transform-spread/src/index.js
@@ -135,7 +135,7 @@ export default declare((api, options) => {
         if (args.length === 1 && args[0].argument.name === "arguments") {
           nodes = [args[0].argument];
         } else {
-          nodes = build(args, scope);
+          nodes = build(args, scope, this);
         }
 
         const first = nodes.shift();
@@ -177,7 +177,7 @@ export default declare((api, options) => {
         let args = node.arguments;
         if (!hasSpread(args)) return;
 
-        const nodes = build(args, scope);
+        const nodes = build(args, scope, this);
 
         const first = nodes.shift();
 

diff --git a/...l-plugin-transform-spread/test/fixtures/spread/method-call-array-literal-babel-7/input.js b/...l-plugin-transform-spread/test/fixtures/spread/method-call-array-literal-babel-7/input.js
@@ -0,0 +1,2 @@
+f(...[1, 2, 3]);
+f(...[1, , 3]);
diff --git a/...ugin-transform-spread/test/fixtures/spread/method-call-array-literal-babel-7/options.json b/...ugin-transform-spread/test/fixtures/spread/method-call-array-literal-babel-7/options.json
@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}
diff --git a/...-plugin-transform-spread/test/fixtures/spread/method-call-array-literal-babel-7/output.js b/...-plugin-transform-spread/test/fixtures/spread/method-call-array-literal-babel-7/output.js
@@ -0,0 +1,2 @@
+f.apply(void 0, [1, 2, 3]);
+f.apply(void 0, babelHelpers.arrayWithoutHoles([1,, 3]));
diff --git a/...ges/babel-plugin-transform-spread/test/fixtures/spread/method-call-array-literal/input.js b/...ges/babel-plugin-transform-spread/test/fixtures/spread/method-call-array-literal/input.js
@@ -1 +1,2 @@
 f(...[1, 2, 3]);
+f(...[1, , 3]);
diff --git a/...babel-plugin-transform-spread/test/fixtures/spread/method-call-array-literal/options.json b/...babel-plugin-transform-spread/test/fixtures/spread/method-call-array-literal/options.json
@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}
diff --git a/...es/babel-plugin-transform-spread/test/fixtures/spread/method-call-array-literal/output.js b/...es/babel-plugin-transform-spread/test/fixtures/spread/method-call-array-literal/output.js
@@ -1 +1,2 @@
 f.apply(void 0, [1, 2, 3]);
+f.apply(void 0, babelHelpers.arrayLikeToArray([1,, 3]));
diff --git a/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression-babel-7/input.js b/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression-babel-7/input.js
@@ -0,0 +1,3 @@
+new Numbers(...nums);
+new Numbers(1, ...nums);
+new Numbers(...[1, , 3]);
diff --git a/...es/babel-plugin-transform-spread/test/fixtures/spread/new-expression-babel-7/options.json b/...es/babel-plugin-transform-spread/test/fixtures/spread/new-expression-babel-7/options.json
@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}
diff --git a/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression-babel-7/output.js b/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression-babel-7/output.js
@@ -0,0 +1,3 @@
+babelHelpers.construct(Numbers, babelHelpers.toConsumableArray(nums));
+babelHelpers.construct(Numbers, [1].concat(babelHelpers.toConsumableArray(nums)));
+babelHelpers.construct(Numbers, babelHelpers.arrayWithoutHoles([1,, 3]));
diff --git a/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression/input.js b/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression/input.js
@@ -1,2 +1,3 @@
 new Numbers(...nums);
 new Numbers(1, ...nums);
+new Numbers(...[1, , 3]);
diff --git a/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression/options.json b/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression/options.json
@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}
diff --git a/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression/output.js b/packages/babel-plugin-transform-spread/test/fixtures/spread/new-expression/output.js
@@ -1,2 +1,3 @@
 babelHelpers.construct(Numbers, babelHelpers.toConsumableArray(nums));
 babelHelpers.construct(Numbers, [1].concat(babelHelpers.toConsumableArray(nums)));
+babelHelpers.construct(Numbers, babelHelpers.arrayLikeToArray([1,, 3]));