fix rest parameters in arrow functions containing wrong arguments ref…

…erence - fixes #11
babel · Oct 31, 2014 · 6696d5f · 6696d5f · sebmck · Oct 31, 2014
1 parent ecedc23
commit 6696d5f
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 2 deletions.
diff --git a/lib/6to5/transformers/_alias-functions.js b/lib/6to5/transformers/_alias-functions.js
@@ -35,6 +35,8 @@ var go = function (getBody, node, file) {
         }
       }
 
+      if (node._ignoreAliasFunctions) return;
+
       var getId;
 
       if (node.type === "Identifier" && node.name === "arguments") {

diff --git a/lib/6to5/transformers/rest-parameters.js b/lib/6to5/transformers/rest-parameters.js
@@ -11,9 +11,14 @@ exports.Function = function (node, parent, file) {
   if (node.params.length) templateName += "-arg";
 
   util.ensureBlock(node);
-  node.body.body.unshift(util.template(templateName, {
+
+  var template = util.template(templateName, {
     SLICE_KEY: file.addDeclaration("slice"),
     VARIABLE_NAME: rest,
     SLICE_ARG: b.literal(node.params.length)
-  }));
+  });
+
+  template.declarations[0].init.arguments[0]._ignoreAliasFunctions = true;
+
+  node.body.body.unshift(template);
 };
diff --git a/test/fixtures/transformation/rest-parameters/arrow-functions/actual.js b/test/fixtures/transformation/rest-parameters/arrow-functions/actual.js
@@ -0,0 +1,3 @@
+var concat = (...arrs) => {
+
+};
diff --git a/test/fixtures/transformation/rest-parameters/arrow-functions/expected.js b/test/fixtures/transformation/rest-parameters/arrow-functions/expected.js
@@ -0,0 +1,5 @@
+"use strict";
+var _slice = Array.prototype.slice;
+var concat = function () {
+  var arrs = _slice.call(arguments);
+};