fix: add ImportExpression visitorKeys

babel · Aug 8, 2020 · 665011e · 665011e
1 parent a827ca4
commit 665011e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/eslint/babel-eslint-parser/src/convert/convertAST.js b/eslint/babel-eslint-parser/src/convert/convertAST.js
@@ -87,6 +87,7 @@ function convertNodes(ast, code) {
   try {
     // Monkey patch visitor keys in order to be able to traverse the estree nodes
     t.VISITOR_KEYS.ChainExpression = VISITOR_KEYS.ChainExpression;
+    t.VISITOR_KEYS.ImportExpression = VISITOR_KEYS.ImportExpression;
     t.VISITOR_KEYS.Property = VISITOR_KEYS.Property;
     t.VISITOR_KEYS.MethodDefinition = VISITOR_KEYS.MethodDefinition;
 
@@ -99,6 +100,7 @@ function convertNodes(ast, code) {
   } finally {
     // These can be safely deleted because they are not defined in the original visitor keys.
     delete t.VISITOR_KEYS.ChainExpression;
+    delete t.VISITOR_KEYS.ImportExpression;
     delete t.VISITOR_KEYS.MethodDefinition;
     delete t.VISITOR_KEYS.Property;
 

diff --git a/eslint/babel-eslint-parser/src/visitor-keys.js b/eslint/babel-eslint-parser/src/visitor-keys.js
@@ -8,6 +8,7 @@ export default Object.assign(
   {
     ChainExpression: ESLINT_VISITOR_KEYS.ChainExpression,
     ExportAllDeclaration: ESLINT_VISITOR_KEYS.ExportAllDeclaration,
+    ImportExpression: ESLINT_VISITOR_KEYS.ImportExpression,
     Literal: ESLINT_VISITOR_KEYS.Literal,
     MethodDefinition: ["decorators"].concat(
       ESLINT_VISITOR_KEYS.MethodDefinition,

diff --git a/eslint/babel-eslint-parser/test/index.js b/eslint/babel-eslint-parser/test/index.js
@@ -569,7 +569,9 @@ describe("Babel and Espree", () => {
 
     it("Dynamic Import", () => {
       parseAndAssertSame(`
-        const a = import('a');
+        const a = import(
+          (async () => await import("module-name"))()
+        );
       `);
     });
   });