fix: Throw correct error types from sed ant class TDZ helpers (#15241)

Fixes #15105

packages/babel-helpers/src/helpers.ts

@@ -612,7 +612,7 @@ helpers.set = helper("7.0.0-beta.0")`
   export default function _set(target, property, value, receiver, isStrict) {
     var s = set(target, property, value, receiver || target);
     if (!s && isStrict) {
-      throw new Error('failed to set property');
+      throw new TypeError('failed to set property');
     }
 
     return value;
@@ -650,7 +650,7 @@ helpers.writeOnlyError = helper("7.12.13")`
 
 helpers.classNameTDZError = helper("7.0.0-beta.0")`
   export default function _classNameTDZError(name) {
-    throw new Error("Class \\"" + name + "\\" cannot be referenced in computed property keys.");
+    throw new ReferenceError("Class \\"" + name + "\\" cannot be referenced in computed property keys.");
   }
 `;
 

packages/babel-plugin-proposal-class-properties/test/fixtures/class-name-tdz/general/exec.js

@@ -0,0 +1,5 @@
+expect(() => {
+  class Foo {
+    [Foo + 1] = 2;
+  };  
+}).toThrow(ReferenceError);

packages/babel-plugin-proposal-class-properties/test/fixtures/class-name-tdz/general/input.js

@@ -0,0 +1,3 @@
+class Foo {
+  [Foo + 1] = 2;
+};

packages/babel-plugin-proposal-class-properties/test/fixtures/class-name-tdz/general/options.json

@@ -0,0 +1,3 @@
+{
+  "plugins": ["proposal-class-properties"]
+}

packages/babel-plugin-proposal-class-properties/test/fixtures/class-name-tdz/general/output.js

@@ -0,0 +1,8 @@
+let _ref;
+_ref = (babelHelpers.classNameTDZError("Foo"), Foo) + 1;
+class Foo {
+  constructor() {
+    babelHelpers.defineProperty(this, _ref, 2);
+  }
+}
+;

packages/babel-plugin-proposal-class-properties/test/fixtures/static-property-tdz/edgest-case/exec.js → packages/babel-plugin-proposal-class-properties/test/fixtures/class-name-tdz/static-edgest-case/exec.js

@@ -2,4 +2,4 @@ expect(() => {
   class A {
     static [{ x: A || 0 }.x];
   }
-}).toThrow();
+}).toThrow(ReferenceError);

packages/babel-plugin-proposal-class-properties/test/fixtures/static-property-tdz/general/exec.js → packages/babel-plugin-proposal-class-properties/test/fixtures/class-name-tdz/static-general/exec.js

@@ -2,4 +2,4 @@ expect(() => {
   class C {
     static [C + 3] = 3;
   }
-}).toThrow();
+}).toThrow(ReferenceError);

packages/babel-plugin-proposal-class-properties/test/fixtures/static-property-tdz/loose/exec.js → packages/babel-plugin-proposal-class-properties/test/fixtures/class-name-tdz/static-loose/exec.js

@@ -2,4 +2,4 @@ expect(() => {
   class C {
     static [C + 3] = 3;
   }
-}).toThrow();
+}).toThrow(ReferenceError);

packages/babel-plugin-transform-classes/test/fixtures/get-set-loose/set-semantics-getter-defined-on-parent/exec.js

@@ -24,7 +24,7 @@ const obj = new Obj();
 // but close enough for loose.
 // expect(() => {
   expect(obj.set()).toBe(3);
-// }).toThrow();
+// }).toThrow(TypeError);
 
 expect(called).toBe(false);
 expect(Base.prototype.test).toBe(1);

packages/babel-plugin-transform-classes/test/fixtures/get-set-loose/set-semantics-getter-defined-on-parent/input.js

@@ -24,7 +24,7 @@ const obj = new Obj();
 // but close enough for loose.
 // expect(() => {
   expect(obj.set()).toBe(3);
-// }).toThrow();
+// }).toThrow(TypeError);
 
 expect(called).toBe(false);
 expect(Base.prototype.test).toBe(1);

packages/babel-plugin-transform-classes/test/fixtures/get-set-loose/set-semantics-getter-defined-on-parent/output.js

@@ -35,7 +35,7 @@ const obj = new Obj();
 // but close enough for loose.
 // expect(() => {
 expect(obj.set()).toBe(3);
-// }).toThrow();
+// }).toThrow(TypeError);
 
 expect(called).toBe(false);
 expect(Base.prototype.test).toBe(1);

packages/babel-plugin-transform-classes/test/fixtures/get-set-loose/set-semantics-not-defined-on-parent-getter-on-obj/exec.js

@@ -19,7 +19,7 @@ const obj = new Obj();
 // expect(obj.set()).toBe(3);
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 
 expect(called).toBe(false);
 expect(Base.prototype.test).toBeUndefined();

packages/babel-plugin-transform-classes/test/fixtures/get-set-loose/set-semantics-not-defined-on-parent-getter-on-obj/input.js

@@ -19,7 +19,7 @@ const obj = new Obj();
 // expect(obj.set()).toBe(3);
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 
 expect(called).toBe(false);
 expect(Base.prototype.test).toBeUndefined();

packages/babel-plugin-transform-classes/test/fixtures/get-set-loose/set-semantics-not-defined-on-parent-getter-on-obj/output.js

@@ -25,7 +25,7 @@ const obj = new Obj();
 // expect(obj.set()).toBe(3);
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(called).toBe(false);
 expect(Base.prototype.test).toBeUndefined();
 expect(Obj.prototype.test).toBeUndefined();

packages/babel-plugin-transform-classes/test/fixtures/get-set/set-semantics-getter-defined-on-parent/exec.js

@@ -21,7 +21,7 @@ Object.defineProperty(Obj.prototype, 'test', {
 const obj = new Obj();
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(called).toBe(false);
 expect(Base.prototype.test).toBe(1);
 expect(Obj.prototype.test).toBe(2);

packages/babel-plugin-transform-classes/test/fixtures/get-set/set-semantics-getter-defined-on-parent/input.js

@@ -21,7 +21,7 @@ expect(() => {
   // this requires helpers to be in file (not external), so they
   // are in "strict" mode code.
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.prototype.test).toBe(1);
 expect(Obj.prototype.test).toBe(2);
 expect(obj.test).toBe(2);

packages/babel-plugin-transform-classes/test/fixtures/get-set/set-semantics-getter-defined-on-parent/output.js

@@ -38,7 +38,7 @@ expect(() => {
   // this requires helpers to be in file (not external), so they
   // are in "strict" mode code.
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.prototype.test).toBe(1);
 expect(Obj.prototype.test).toBe(2);
 expect(obj.test).toBe(2);

packages/babel-plugin-transform-classes/test/fixtures/spec/super-reference-in-prop-exression/exec.js

@@ -14,5 +14,5 @@ class B extends A {
 
 expect(() => {
   new B();
-}).toThrow();
+}).toThrow(ReferenceError);
 expect(called).toBe(false);

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-data-non-writable-defined-on-parent/exec.js

@@ -18,6 +18,6 @@ Object.setPrototypeOf(obj, Base);
 
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.test).toBe(1);
 expect(obj.test).toBe(2);

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-getter-defined-on-parent/exec.js

@@ -18,7 +18,7 @@ Object.setPrototypeOf(obj, Base);
 
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(called).toBe(false);
 expect(Base.test).toBe(1);
 expect(obj.test).toBe(2);

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-getter-defined-on-parent/input.js

@@ -18,6 +18,6 @@ expect(() => {
   // this requires helpers to be in file (not external), so they
   // are in "strict" mode code.
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.test).toBe(1);
 expect(obj.test).toBe(2);

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-getter-defined-on-parent/output.js

@@ -17,6 +17,6 @@ expect(() => {
   // this requires helpers to be in file (not external), so they
   // are in "strict" mode code.
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.test).toBe(1);
 expect(obj.test).toBe(2);

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-not-defined-on-parent-data-non-writable-on-obj/exec.js

@@ -17,7 +17,7 @@ Object.setPrototypeOf(obj, Base);
 
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.test).toBeUndefined();
 expect(obj.test).toBe(2);
 

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-not-defined-on-parent-data-non-writable-on-obj/input.js

@@ -17,7 +17,7 @@ Object.setPrototypeOf(obj, Base);
 
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.test).toBeUndefined();
 expect(obj.test).toBe(2);
 

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-not-defined-on-parent-data-non-writable-on-obj/output.js

@@ -16,7 +16,7 @@ Object.defineProperty(obj, 'test', {
 Object.setPrototypeOf(obj, Base);
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.test).toBeUndefined();
 expect(obj.test).toBe(2);
 const desc = Object.getOwnPropertyDescriptor(obj, 'test');

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-not-defined-on-parent-getter-on-obj/exec.js

@@ -16,7 +16,7 @@ Object.setPrototypeOf(obj, Base);
 
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(called).toBe(false);
 expect(Base.test).toBeUndefined();
 expect(obj.test).toBeUndefined();

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-not-defined-on-parent-getter-on-obj/input.js

@@ -15,6 +15,6 @@ expect(() => {
   // this requires helpers to be in file (not external), so they
   // are in "strict" mode code.
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.test).toBeUndefined();
 expect(obj.test).toBeUndefined();

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-not-defined-on-parent-getter-on-obj/output.js

@@ -13,6 +13,6 @@ expect(() => {
   // this requires helpers to be in file (not external), so they
   // are in "strict" mode code.
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(Base.test).toBeUndefined();
 expect(obj.test).toBeUndefined();

packages/babel-plugin-transform-object-super/test/fixtures/get-set/set-semantics-not-defined-on-parent-setter-on-obj/exec.js

@@ -16,7 +16,7 @@ Object.setPrototypeOf(obj, Base);
 
 expect(() => {
   obj.set();
-}).toThrow();
+}).toThrow(TypeError);
 expect(value).toBe(2);
 expect(Base.test).toBeUndefined();
 expect(obj.test).toBeUndefined();