[parser] Enable "exportNamespaceFrom" by default (#10521)

babel · Oct 29, 2019 · 4cd93ab · 4cd93ab
1 parent d248e2d
commit 4cd93ab
Show file tree

Hide file tree

Showing 22 changed files with 263 additions and 27 deletions.
diff --git a/packages/babel-parser/src/parser/statement.js b/packages/babel-parser/src/parser/statement.js
@@ -1719,7 +1719,6 @@ export default class StatementParser extends ExpressionParser {
   maybeParseExportNamespaceSpecifier(node: N.Node): boolean {
     if (this.isContextual("as")) {
       if (!node.specifiers) node.specifiers = [];
-      this.expectPlugin("exportNamespaceFrom");
 
       const specifier = this.startNodeAt(
         this.state.lastTokStart,

diff --git a/...l/export-extensions/ns-and-named/input.js → ...2020/export-ns-from/ns-and-named/input.js b/...l/export-extensions/ns-and-named/input.js → ...2020/export-ns-from/ns-and-named/input.js
diff --git a/...xport-extensions/ns-and-named/output.json → ...0/export-ns-from/ns-and-named/output.json b/...xport-extensions/ns-and-named/output.json → ...0/export-ns-from/ns-and-named/output.json
diff --git a/...tal/export-extensions/ns-default/input.js → ...es2020/export-ns-from/ns-default/input.js b/...tal/export-extensions/ns-default/input.js → ...es2020/export-ns-from/ns-default/input.js
diff --git a/.../export-extensions/ns-default/output.json → ...020/export-ns-from/ns-default/output.json b/.../export-extensions/ns-default/output.json → ...020/export-ns-from/ns-default/output.json
diff --git a/...ntal/_no-plugin/export-namespace/input.js → ...ixtures/es2020/export-ns-from/ns/input.js b/...ntal/_no-plugin/export-namespace/input.js → ...ixtures/es2020/export-ns-from/ns/input.js
diff --git a/...rimental/export-extensions/ns/output.json → ...ures/es2020/export-ns-from/ns/output.json b/...rimental/export-extensions/ns/output.json → ...ures/es2020/export-ns-from/ns/output.json
diff --git a/packages/babel-parser/test/fixtures/es2020/export-ns-from/options.json b/packages/babel-parser/test/fixtures/es2020/export-ns-from/options.json
@@ -0,0 +1,3 @@
+{
+  "sourceType": "module"
+}
diff --git a/packages/babel-parser/test/fixtures/experimental/_no-plugin/export-namespace/options.json b/packages/babel-parser/test/fixtures/experimental/_no-plugin/export-namespace/options.json
diff --git a/...ges/babel-parser/test/fixtures/experimental/export-extensions/default-and-ns/options.json b/...ges/babel-parser/test/fixtures/experimental/export-extensions/default-and-ns/options.json
@@ -1,4 +1,4 @@
 {
-  "plugins": ["exportDefaultFrom", "exportNamespaceFrom"],
+  "plugins": ["exportDefaultFrom"],
   "sourceType": "module"
 }
diff --git a/packages/babel-parser/test/fixtures/experimental/export-extensions/ns-and-named/options.json b/packages/babel-parser/test/fixtures/experimental/export-extensions/ns-and-named/options.json
diff --git a/packages/babel-parser/test/fixtures/experimental/export-extensions/ns-default/options.json b/packages/babel-parser/test/fixtures/experimental/export-extensions/ns-default/options.json
diff --git a/packages/babel-parser/test/fixtures/experimental/export-extensions/ns/input.js b/packages/babel-parser/test/fixtures/experimental/export-extensions/ns/input.js
diff --git a/packages/babel-parser/test/fixtures/experimental/export-extensions/ns/options.json b/packages/babel-parser/test/fixtures/experimental/export-extensions/ns/options.json
diff --git a/packages/babel-parser/test/fixtures/flow/declare-export/export-star-as/options.json b/packages/babel-parser/test/fixtures/flow/declare-export/export-star-as/options.json
@@ -1,3 +1,3 @@
 {
-  "plugins": ["jsx", "flow", "exportNamespaceFrom"]
+  "plugins": ["jsx", "flow"]
 }
diff --git a/packages/babel-parser/test/fixtures/flow/type-exports/star-as-from/options.json b/packages/babel-parser/test/fixtures/flow/type-exports/star-as-from/options.json
@@ -1,5 +1,5 @@
 {
   "sourceType": "module",
-  "plugins": ["flow", "exportNamespaceFrom"],
+  "plugins": ["flow"],
   "throws": "Unexpected token (1:14)"
 }
diff --git a/packages/babel-parser/test/fixtures/placeholders/export/options.json b/packages/babel-parser/test/fixtures/placeholders/export/options.json
@@ -1,4 +1,4 @@
 {
-  "plugins": ["placeholders", "exportDefaultFrom", "exportNamespaceFrom"],
+  "plugins": ["placeholders", "exportDefaultFrom"],
   "sourceType": "module"
 }
diff --git a/packages/babel-parser/test/fixtures/placeholders/export/star-from-2/options.json b/packages/babel-parser/test/fixtures/placeholders/export/star-from-2/options.json
@@ -1,5 +1,4 @@
 {
   "plugins": ["placeholders"],
-  "sourceType": "module",
-  "throws": "This experimental syntax requires enabling the parser plugin: 'exportNamespaceFrom' (1:9)"
+  "sourceType": "module"
 }
diff --git a/packages/babel-parser/test/fixtures/placeholders/export/star-from-2/output.json b/packages/babel-parser/test/fixtures/placeholders/export/star-from-2/output.json
@@ -0,0 +1,120 @@
+{
+  "type": "File",
+  "start": 0,
+  "end": 33,
+  "loc": {
+    "start": {
+      "line": 1,
+      "column": 0
+    },
+    "end": {
+      "line": 1,
+      "column": 33
+    }
+  },
+  "program": {
+    "type": "Program",
+    "start": 0,
+    "end": 33,
+    "loc": {
+      "start": {
+        "line": 1,
+        "column": 0
+      },
+      "end": {
+        "line": 1,
+        "column": 33
+      }
+    },
+    "sourceType": "module",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExportNamedDeclaration",
+        "start": 0,
+        "end": 33,
+        "loc": {
+          "start": {
+            "line": 1,
+            "column": 0
+          },
+          "end": {
+            "line": 1,
+            "column": 33
+          }
+        },
+        "specifiers": [
+          {
+            "type": "ExportNamespaceSpecifier",
+            "start": 7,
+            "end": 20,
+            "loc": {
+              "start": {
+                "line": 1,
+                "column": 7
+              },
+              "end": {
+                "line": 1,
+                "column": 20
+              }
+            },
+            "exported": {
+              "type": "Placeholder",
+              "start": 12,
+              "end": 20,
+              "loc": {
+                "start": {
+                  "line": 1,
+                  "column": 12
+                },
+                "end": {
+                  "line": 1,
+                  "column": 20
+                }
+              },
+              "name": {
+                "type": "Identifier",
+                "start": 14,
+                "end": 18,
+                "loc": {
+                  "start": {
+                    "line": 1,
+                    "column": 14
+                  },
+                  "end": {
+                    "line": 1,
+                    "column": 18
+                  },
+                  "identifierName": "STAR"
+                },
+                "name": "STAR"
+              },
+              "expectedNode": "Identifier"
+            }
+          }
+        ],
+        "source": {
+          "type": "StringLiteral",
+          "start": 26,
+          "end": 32,
+          "loc": {
+            "start": {
+              "line": 1,
+              "column": 26
+            },
+            "end": {
+              "line": 1,
+              "column": 32
+            }
+          },
+          "extra": {
+            "rawValue": "file",
+            "raw": "\"file\""
+          },
+          "value": "file"
+        }
+      }
+    ],
+    "directives": []
+  }
+}
diff --git a/packages/babel-parser/test/fixtures/placeholders/export/star-from-3/options.json b/packages/babel-parser/test/fixtures/placeholders/export/star-from-3/options.json
@@ -1,5 +1,4 @@
 {
   "plugins": ["placeholders"],
-  "sourceType": "module",
-  "throws": "This experimental syntax requires enabling the parser plugin: 'exportNamespaceFrom' (1:9)"
+  "sourceType": "module"
 }
diff --git a/packages/babel-parser/test/fixtures/placeholders/export/star-from-3/output.json b/packages/babel-parser/test/fixtures/placeholders/export/star-from-3/output.json
@@ -0,0 +1,133 @@
+{
+  "type": "File",
+  "start": 0,
+  "end": 35,
+  "loc": {
+    "start": {
+      "line": 1,
+      "column": 0
+    },
+    "end": {
+      "line": 1,
+      "column": 35
+    }
+  },
+  "program": {
+    "type": "Program",
+    "start": 0,
+    "end": 35,
+    "loc": {
+      "start": {
+        "line": 1,
+        "column": 0
+      },
+      "end": {
+        "line": 1,
+        "column": 35
+      }
+    },
+    "sourceType": "module",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExportNamedDeclaration",
+        "start": 0,
+        "end": 35,
+        "loc": {
+          "start": {
+            "line": 1,
+            "column": 0
+          },
+          "end": {
+            "line": 1,
+            "column": 35
+          }
+        },
+        "specifiers": [
+          {
+            "type": "ExportNamespaceSpecifier",
+            "start": 7,
+            "end": 20,
+            "loc": {
+              "start": {
+                "line": 1,
+                "column": 7
+              },
+              "end": {
+                "line": 1,
+                "column": 20
+              }
+            },
+            "exported": {
+              "type": "Placeholder",
+              "start": 12,
+              "end": 20,
+              "loc": {
+                "start": {
+                  "line": 1,
+                  "column": 12
+                },
+                "end": {
+                  "line": 1,
+                  "column": 20
+                }
+              },
+              "name": {
+                "type": "Identifier",
+                "start": 14,
+                "end": 18,
+                "loc": {
+                  "start": {
+                    "line": 1,
+                    "column": 14
+                  },
+                  "end": {
+                    "line": 1,
+                    "column": 18
+                  },
+                  "identifierName": "STAR"
+                },
+                "name": "STAR"
+              },
+              "expectedNode": "Identifier"
+            }
+          }
+        ],
+        "source": {
+          "type": "Placeholder",
+          "start": 26,
+          "end": 34,
+          "loc": {
+            "start": {
+              "line": 1,
+              "column": 26
+            },
+            "end": {
+              "line": 1,
+              "column": 34
+            }
+          },
+          "name": {
+            "type": "Identifier",
+            "start": 28,
+            "end": 32,
+            "loc": {
+              "start": {
+                "line": 1,
+                "column": 28
+              },
+              "end": {
+                "line": 1,
+                "column": 32
+              },
+              "identifierName": "FILE"
+            },
+            "name": "FILE"
+          },
+          "expectedNode": "StringLiteral"
+        }
+      }
+    ],
+    "directives": []
+  }
+}
diff --git a/packages/babel-parser/typings/babel-parser.d.ts b/packages/babel-parser/typings/babel-parser.d.ts
@@ -106,7 +106,7 @@ export type ParserPlugin =
     'dynamicImport' |
     'estree' |
     'exportDefaultFrom' |
-    'exportNamespaceFrom' |
+    'exportNamespaceFrom' | // deprecated
     'flow' |
     'flowComments' |
     'functionBind' |