Review

babel · Sep 8, 2023 · 48d5a27 · 48d5a27
1 parent 17c8ce4
commit 48d5a27
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/packages/babel-preset-typescript/src/plugin-rewrite-ts-imports.ts b/packages/babel-preset-typescript/src/plugin-rewrite-ts-imports.ts
@@ -2,18 +2,20 @@ import { declare } from "@babel/helper-plugin-utils";
 import type { types as t } from "@babel/core";
 import type { NodePath } from "@babel/traverse";
 
-export default declare(function () {
+export default declare(function ({ types: t }) {
   return {
+    name: "preset-typescript/plugin-rewrite-ts-imports",
     visitor: {
-      "ImportDeclaration|ExportAllDeclaration|ExportNamedDeclaration"(
-        path: NodePath<
-          | t.ImportDeclaration
-          | t.ExportAllDeclaration
-          | t.ExportNamedDeclaration
-        >,
-      ) {
-        const { source } = path.node;
-        if (source) {
+      "ImportDeclaration|ExportAllDeclaration|ExportNamedDeclaration"({
+        node,
+      }: NodePath<
+        t.ImportDeclaration | t.ExportAllDeclaration | t.ExportNamedDeclaration
+      >) {
+        const { source } = node;
+        const kind = t.isImportDeclaration(node)
+          ? node.importKind
+          : node.exportKind;
+        if (kind === "value" && source && /[\\/]/.test(source.value)) {
           source.value = source.value.replace(/(\.[mc]?)ts$/, "$1js");
         }
       },

diff --git a/packages/babel-preset-typescript/test/fixtures/opts/rewriteImportExtensions/input.ts b/packages/babel-preset-typescript/test/fixtures/opts/rewriteImportExtensions/input.ts
@@ -1,3 +1,6 @@
 import "./a.ts";
 import "./a.mts";
 import "./a.cts";
+import "a-package/file.ts";
+// Bare import, it's either a node package or remapped by an import map
+import "soundcloud.ts";
diff --git a/packages/babel-preset-typescript/test/fixtures/opts/rewriteImportExtensions/output.mjs b/packages/babel-preset-typescript/test/fixtures/opts/rewriteImportExtensions/output.mjs
@@ -1,3 +1,6 @@
 import "./a.js";
 import "./a.mjs";
 import "./a.cjs";
+import "a-package/file.js";
+// Bare import, it's either a node package or remapped by an import map
+import "soundcloud.ts";