Skip to content

Commit

Permalink
Miscellaneous perf tweak (#10421)
Browse files Browse the repository at this point in the history
* refactor: early return on hot path

* refactor: read next2 only when next is dot

* perf: mini refactor
  • Loading branch information
JLHwung authored and nicolo-ribaudo committed Sep 10, 2019
1 parent 610d6bd commit 4395c22
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
5 changes: 3 additions & 2 deletions packages/babel-parser/src/parser/comments.js
Expand Up @@ -39,10 +39,11 @@ export default class CommentsParser extends BaseParser {
}

adjustCommentsAfterTrailingComma(node: Node, elements: Node[]) {
if (elements.length === 0) {
if (this.state.leadingComments.length === 0) {
return;
}
if (this.state.leadingComments.length === 0) {

if (elements.length === 0) {
return;
}

Expand Down
14 changes: 8 additions & 6 deletions packages/babel-parser/src/tokenizer/index.js
Expand Up @@ -234,8 +234,8 @@ export default class Tokenizer extends LocationParser {
skipBlockComment(): void {
const startLoc = this.state.curPosition();
const start = this.state.pos;
const end = this.input.indexOf("*/", (this.state.pos += 2));
if (end === -1) this.raise(this.state.pos - 2, "Unterminated comment");
const end = this.input.indexOf("*/", this.state.pos + 2);
if (end === -1) this.raise(start, "Unterminated comment");

this.state.pos = end + 2;
lineBreakG.lastIndex = start;
Expand Down Expand Up @@ -404,8 +404,10 @@ export default class Tokenizer extends LocationParser {
return;
}

const next2 = this.input.charCodeAt(this.state.pos + 2);
if (next === charCodes.dot && next2 === charCodes.dot) {
if (
next === charCodes.dot &&
this.input.charCodeAt(this.state.pos + 2) === charCodes.dot
) {
this.state.pos += 3;
this.finishToken(tt.ellipsis);
} else {
Expand Down Expand Up @@ -900,9 +902,9 @@ export default class Tokenizer extends LocationParser {
let val;

if (this.hasPlugin("numericSeparator")) {
const prev = this.input.charCodeAt(this.state.pos - 1);
const next = this.input.charCodeAt(this.state.pos + 1);
if (code === charCodes.underscore) {
const prev = this.input.charCodeAt(this.state.pos - 1);
const next = this.input.charCodeAt(this.state.pos + 1);
if (allowedSiblings.indexOf(next) === -1) {
this.raise(this.state.pos, "Invalid or unexpected token");
}
Expand Down

0 comments on commit 4395c22

Please sign in to comment.