Fix printing of comments before => (#15160)

Fixes #15161
babel · Nov 8, 2022 · 4285d5f · 4285d5f
1 parent 156b608
commit 4285d5f
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 2 deletions.
diff --git a/packages/babel-generator/src/generators/methods.ts b/packages/babel-generator/src/generators/methods.ts
@@ -11,7 +11,10 @@ export function _params(
   this._parameters(node.params, node);
   this.token(")");
 
-  this.print(node.returnType, node, node.type === "ArrowFunctionExpression");
+  const noLineTerminator = node.type === "ArrowFunctionExpression";
+  this.print(node.returnType, node, noLineTerminator);
+
+  this._noLineTerminator = noLineTerminator;
 }
 
 export function _parameters(

diff --git a/packages/babel-generator/test/fixtures/regression/15161/input.js b/packages/babel-generator/test/fixtures/regression/15161/input.js
@@ -0,0 +1,3 @@
+var test = (/* placeholder */) => {
+  /* Unused */
+}
diff --git a/packages/babel-generator/test/fixtures/regression/15161/options.json b/packages/babel-generator/test/fixtures/regression/15161/options.json
@@ -0,0 +1,3 @@
+{
+  "comments": false
+}
diff --git a/packages/babel-generator/test/fixtures/regression/15161/output.js b/packages/babel-generator/test/fixtures/regression/15161/output.js
@@ -0,0 +1,3 @@
+var test = (
+) => {
+};
diff --git a/packages/babel-generator/test/index.js b/packages/babel-generator/test/index.js
@@ -1151,7 +1151,7 @@ describe("programmatic generation", function () {
       expect(generate(expr).code).toMatchInlineSnapshot(`"1 + 2 /*foo*/"`);
     });
 
-    it("comment skipped because of newlines", () => {
+    it("comment skipped in arrow function because of newlines", () => {
       const arrow = t.arrowFunctionExpression(
         [t.identifier("x"), t.identifier("y")],
         t.identifier("z"),
@@ -1166,6 +1166,23 @@ describe("programmatic generation", function () {
         line*/"
       `);
     });
+
+    it("comment in arrow function with return type", () => {
+      const arrow = t.arrowFunctionExpression(
+        [t.identifier("x"), t.identifier("y")],
+        t.identifier("z"),
+      );
+      arrow.returnType = t.tsTypeAnnotation(t.tsAnyKeyword());
+      arrow.returnType.trailingComments = [
+        { type: "CommentBlock", value: "foo" },
+        // This comment is dropped. There is no way to safely print it
+        // as a trailingComment of the return type.
+        { type: "CommentBlock", value: "new\nline" },
+      ];
+      expect(generate(arrow).code).toMatchInlineSnapshot(
+        `"(x, y): any /*foo*/ => z"`,
+      );
+    });
   });
 });