Fix compilation of nested super(...) calls (#14709)

babel · Jul 1, 2022 · 3c14351 · 3c14351
1 parent 2bbcd1e
commit 3c14351
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 3 deletions.
diff --git a/packages/babel-plugin-transform-classes/src/transformClass.ts b/packages/babel-plugin-transform-classes/src/transformClass.ts
@@ -399,22 +399,22 @@ export default function transformClass(
       );
     }
 
-    const bareSupers = new Set<NodePath<t.CallExpression>>();
+    const bareSupers: NodePath<t.CallExpression>[] = [];
     path.traverse(
       traverse.visitors.merge([
         environmentVisitor,
         {
           Super(path) {
             const { node, parentPath } = path;
             if (parentPath.isCallExpression({ callee: node })) {
-              bareSupers.add(parentPath);
+              bareSupers.unshift(parentPath);
             }
           },
         } as Visitor,
       ]),
     );
 
-    let guaranteedSuperBeforeFinish = !!bareSupers.size;
+    let guaranteedSuperBeforeFinish = !!bareSupers.length;
 
     for (const bareSuper of bareSupers) {
       wrapSuperCall(bareSuper, classState.superName, thisRef, body);

diff --git a/packages/babel-plugin-transform-classes/test/fixtures/regression/14652/input.js b/packages/babel-plugin-transform-classes/test/fixtures/regression/14652/input.js
@@ -0,0 +1,5 @@
+class C extends P {
+  constructor() {
+    super(super(super()))
+  }
+}
diff --git a/packages/babel-plugin-transform-classes/test/fixtures/regression/14652/output.js b/packages/babel-plugin-transform-classes/test/fixtures/regression/14652/output.js
@@ -0,0 +1,16 @@
+var C = /*#__PURE__*/function (_P) {
+  "use strict";
+
+  babelHelpers.inherits(C, _P);
+
+  var _super = babelHelpers.createSuper(C);
+
+  function C() {
+    var _this;
+
+    babelHelpers.classCallCheck(this, C);
+    return _super.call(this, _this = _super.call(this, _this = _super.call(this)));
+  }
+
+  return babelHelpers.createClass(C);
+}(P);