fix(jsx): do not throw on generated element in development mode (#12017)

* Fix `jsxDEV` for generated elements * Throw invariant error * Add test * test: revise test layout * fix: node 6 does not support trailing comma * Use undefined node Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
babel · Aug 31, 2020 · 371e152 · 371e152
1 parent ce6a7f1
commit 371e152
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 1 deletion.
diff --git a/packages/babel-helper-builder-react-jsx-experimental/src/index.js b/packages/babel-helper-builder-react-jsx-experimental/src/index.js
@@ -437,7 +437,7 @@ You can set \`throwIfNamespace: false\` to bypass this warning.`,
     const location = path.node.loc;
     if (!location) {
       // the element was generated and doesn't have location information
-      return;
+      return path.scope.buildUndefinedNode();
     }
 
     if (!state.fileNameIdentifier) {

diff --git a/...lugin-transform-react-jsx-development/test/fixtures/cross-platform/generated-jsx/input.js b/...lugin-transform-react-jsx-development/test/fixtures/cross-platform/generated-jsx/input.js
@@ -0,0 +1 @@
+// empty
diff --git a/...n-transform-react-jsx-development/test/fixtures/cross-platform/generated-jsx/options.json b/...n-transform-react-jsx-development/test/fixtures/cross-platform/generated-jsx/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "./plugin.js",
+    ["transform-react-jsx-development", { "runtime": "automatic" }]
+  ]
+}
diff --git a/...ugin-transform-react-jsx-development/test/fixtures/cross-platform/generated-jsx/output.js b/...ugin-transform-react-jsx-development/test/fixtures/cross-platform/generated-jsx/output.js
@@ -0,0 +1,6 @@
+// empty
+
+var _reactJsxDevRuntime = require("react/jsx-dev-runtime");
+
+/*#__PURE__*/
+_reactJsxDevRuntime.jsxDEV("div", {}, void 0, false, void 0, this)
diff --git a/...ugin-transform-react-jsx-development/test/fixtures/cross-platform/generated-jsx/plugin.js b/...ugin-transform-react-jsx-development/test/fixtures/cross-platform/generated-jsx/plugin.js
@@ -0,0 +1,18 @@
+module.exports = function ({ types: t }) {
+  return {
+    visitor: {
+      Program: {
+        enter(path) {
+          path.pushContainer(
+            "body",
+            t.JSXElement(
+              t.JSXOpeningElement(t.JSXIdentifier("div"), [], false),
+              t.JSXClosingElement(t.JSXIdentifier("div")),
+              []
+            )
+          );
+        }
+      }
+    }
+  };
+};