Merge pull request #6052 from babel/array-destructuring-hole

Array destructuring hole
babel · Aug 4, 2017 · 30c4d6b · 30c4d6b
2 parents 8c457e9 + 0e58007
commit 30c4d6b
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 0 deletions.
diff --git a/packages/babel-plugin-transform-es2015-modules-commonjs/src/index.js b/packages/babel-plugin-transform-es2015-modules-commonjs/src/index.js
@@ -119,6 +119,8 @@ export default function() {
         }
       } else if (left.isArrayPattern()) {
         for (const element of left.node.elements) {
+          if (!element) continue;
+
           const name = element.name;
 
           const exports = this.exports[name];

diff --git a/...gin-transform-es2015-modules-commonjs/test/fixtures/interop/export-destructured/actual.js b/...gin-transform-es2015-modules-commonjs/test/fixtures/interop/export-destructured/actual.js
@@ -12,3 +12,7 @@ export function f2 () {
 export function f3 () {
   [x, y, z] = [3, 4, 5]
 }
+
+export function f4 () {
+  [x, , y] = [3, 4, 5]
+}
diff --git a/...n-transform-es2015-modules-commonjs/test/fixtures/interop/export-destructured/expected.js b/...n-transform-es2015-modules-commonjs/test/fixtures/interop/export-destructured/expected.js
@@ -6,6 +6,7 @@ Object.defineProperty(exports, "__esModule", {
 exports.f1 = f1;
 exports.f2 = f2;
 exports.f3 = f3;
+exports.f4 = f4;
 let x = exports.x = 0;
 let y = exports.y = 0;
 
@@ -35,3 +36,9 @@ function f3() {
   exports.y = y;
   exports.x = x;
 }
+
+function f4() {
+  [x,, y] = [3, 4, 5];
+  exports.y = y;
+  exports.x = x;
+}
diff --git a/...bel-plugin-transform-es2015-spread/test/fixtures/spread/array-literal-with-hole/actual.js b/...bel-plugin-transform-es2015-spread/test/fixtures/spread/array-literal-with-hole/actual.js
@@ -0,0 +1 @@
+var arr = [ 'a',, 'b', ...c ];
diff --git a/...l-plugin-transform-es2015-spread/test/fixtures/spread/array-literal-with-hole/expected.js b/...l-plugin-transform-es2015-spread/test/fixtures/spread/array-literal-with-hole/expected.js
@@ -0,0 +1 @@
+var arr = ['a',, 'b'].concat(babelHelpers.toConsumableArray(c));