Skip to content

Commit

Permalink
feat: add destructuring-private to standalone
Browse files Browse the repository at this point in the history
  • Loading branch information
JLHwung committed Mar 2, 2022
1 parent ed3a81d commit 2282605
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/babel-standalone/package.json
Expand Up @@ -14,6 +14,7 @@
"@babel/plugin-proposal-class-properties": "workspace:^",
"@babel/plugin-proposal-class-static-block": "workspace:^",
"@babel/plugin-proposal-decorators": "workspace:^",
"@babel/plugin-proposal-destructuring-private": "workspace:^",
"@babel/plugin-proposal-do-expressions": "workspace:^",
"@babel/plugin-proposal-dynamic-import": "workspace:^",
"@babel/plugin-proposal-export-default-from": "workspace:^",
Expand Down
1 change: 1 addition & 0 deletions packages/babel-standalone/scripts/pluginConfig.json
Expand Up @@ -25,6 +25,7 @@
"proposal-class-properties",
"proposal-class-static-block",
"proposal-decorators",
"proposal-destructuring-private",
"proposal-do-expressions",
"proposal-dynamic-import",
"proposal-export-default-from",
Expand Down
3 changes: 3 additions & 0 deletions packages/babel-standalone/src/generated/plugins.ts
Expand Up @@ -28,6 +28,7 @@ import proposalAsyncGeneratorFunctions from "@babel/plugin-proposal-async-genera
import proposalClassProperties from "@babel/plugin-proposal-class-properties";
import proposalClassStaticBlock from "@babel/plugin-proposal-class-static-block";
import proposalDecorators from "@babel/plugin-proposal-decorators";
import proposalDestructuringPrivate from "@babel/plugin-proposal-destructuring-private";
import proposalDoExpressions from "@babel/plugin-proposal-do-expressions";
import proposalDynamicImport from "@babel/plugin-proposal-dynamic-import";
import proposalExportDefaultFrom from "@babel/plugin-proposal-export-default-from";
Expand Down Expand Up @@ -124,6 +125,7 @@ export {
proposalClassProperties,
proposalClassStaticBlock,
proposalDecorators,
proposalDestructuringPrivate,
proposalDoExpressions,
proposalDynamicImport,
proposalExportDefaultFrom,
Expand Down Expand Up @@ -221,6 +223,7 @@ export const all: { [k: string]: any } = {
"proposal-class-properties": proposalClassProperties,
"proposal-class-static-block": proposalClassStaticBlock,
"proposal-decorators": proposalDecorators,
"proposal-destructuring-private": proposalDestructuringPrivate,
"proposal-do-expressions": proposalDoExpressions,
"proposal-dynamic-import": proposalDynamicImport,
"proposal-export-default-from": proposalExportDefaultFrom,
Expand Down
2 changes: 1 addition & 1 deletion packages/babel-standalone/src/preset-stage-2.ts
Expand Up @@ -23,7 +23,7 @@ export default (_: any, opts: any = {}) => {
decoratorsBeforeExport,
},
],
babelPlugins.syntaxDestructuringPrivate,
babelPlugins.proposalDestructuringPrivate,
[
babelPlugins.proposalPipelineOperator,
{ proposal: pipelineProposal, topicToken: pipelineTopicToken },
Expand Down
14 changes: 14 additions & 0 deletions packages/babel-standalone/test/preset-stage-1.test.js
Expand Up @@ -62,5 +62,19 @@ const require = createRequire(import.meta.url);
}).code;
expect(output).toMatch("babelHelpers.applyDecs");
});
it("should support private destructuring", () => {
const output = Babel.transform("class C { #x; m({ #x: x}) {} }", {
plugins: [["external-helpers", { helperVersion: "7.100.0" }]],
presets: [
[
"stage-1",
{
decoratorsVersion: "2021-12",
},
],
],
}).code;
expect(output).not.toContain("#x:");
});
},
);
18 changes: 18 additions & 0 deletions yarn.lock
Expand Up @@ -1328,6 +1328,23 @@ __metadata:
languageName: unknown
linkType: soft

"@babel/plugin-proposal-destructuring-private@workspace:^, @babel/plugin-proposal-destructuring-private@workspace:packages/babel-plugin-proposal-destructuring-private":
version: 0.0.0-use.local
resolution: "@babel/plugin-proposal-destructuring-private@workspace:packages/babel-plugin-proposal-destructuring-private"
dependencies:
"@babel/core": "workspace:^"
"@babel/helper-plugin-test-runner": "workspace:^"
"@babel/helper-plugin-utils": "workspace:^"
"@babel/plugin-syntax-destructuring-private": "workspace:^"
"@babel/plugin-transform-destructuring": "workspace:^"
"@babel/plugin-transform-parameters": "workspace:^"
"@babel/traverse": "workspace:^"
"@babel/types": "workspace:^"
peerDependencies:
"@babel/core": ^7.17.0
languageName: unknown
linkType: soft

"@babel/plugin-proposal-do-expressions@workspace:^, @babel/plugin-proposal-do-expressions@workspace:packages/babel-plugin-proposal-do-expressions":
version: 0.0.0-use.local
resolution: "@babel/plugin-proposal-do-expressions@workspace:packages/babel-plugin-proposal-do-expressions"
Expand Down Expand Up @@ -3598,6 +3615,7 @@ __metadata:
"@babel/plugin-proposal-class-properties": "workspace:^"
"@babel/plugin-proposal-class-static-block": "workspace:^"
"@babel/plugin-proposal-decorators": "workspace:^"
"@babel/plugin-proposal-destructuring-private": "workspace:^"
"@babel/plugin-proposal-do-expressions": "workspace:^"
"@babel/plugin-proposal-dynamic-import": "workspace:^"
"@babel/plugin-proposal-export-default-from": "workspace:^"
Expand Down

0 comments on commit 2282605

Please sign in to comment.