Skip to content

Commit

Permalink
feature: Support pure expressions in transform-react-constant-elements
Browse files Browse the repository at this point in the history
  • Loading branch information
STRML committed Nov 5, 2016
1 parent 723ca0e commit 189820b
Show file tree
Hide file tree
Showing 7 changed files with 53 additions and 1 deletion.
Expand Up @@ -15,7 +15,7 @@ export default function () {
return stop();
}

if (path.isJSXIdentifier() || path.isIdentifier() || path.isJSXMemberExpression()) {
if (path.isJSXIdentifier() || path.isIdentifier() || path.isJSXMemberExpression() || path.isPure()) {
return;
}

Expand Down
@@ -0,0 +1,5 @@
function render(offset) {
return function () {
return <div tabIndex={offset + 1} />;
};
}
@@ -0,0 +1,8 @@
function render(offset) {
var _ref = <div tabIndex={offset + 1} />;

return function () {
return _ref;
};
}

@@ -0,0 +1,10 @@
const OFFSET = 3;

var Foo = React.createClass({
render: function () {
return (
<div tabIndex={OFFSET + 1} />
);
}
});

@@ -0,0 +1,10 @@
const OFFSET = 3;

var _ref = <div tabIndex={OFFSET + 1} />;

var Foo = React.createClass({
render: function () {
return _ref;
}
});

@@ -0,0 +1,11 @@
var Foo = React.createClass({
render: function () {
return (
<div data-text={
"Some text, " +
"and some more too."
} />
);
}
});

@@ -0,0 +1,8 @@
var _ref = <div data-text={"Some text, " + "and some more too."} />;

var Foo = React.createClass({
render: function () {
return _ref;
}
});

0 comments on commit 189820b

Please sign in to comment.