Skip to content

Commit

Permalink
remove babel-traverse from references to avoid TS cycle dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
JLHwung committed Apr 8, 2021
1 parent 96a37f6 commit 16c5ba6
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Expand Up @@ -72,6 +72,8 @@ packages/babel-standalone/babel.min.js
/.vscode

tsconfig.json
# Manually edited tsconfig.json
!/packages/babel-helper-hoist-variables/tsconfig.json
tsconfig.tsbuildinfo

/test/runtime-integration/*/output.js
Expand Down
5 changes: 3 additions & 2 deletions packages/babel-helper-hoist-variables/package.json
Expand Up @@ -13,9 +13,10 @@
"access": "public"
},
"main": "lib/index.js",
"TODO": "The @babel/traverse dependency is only needed for the NodePath TS type. After converting @babel/core to TS we can import NodePath from there.",
"dependencies": {
"@babel/traverse": "workspace:^7.13.0",
"@babel/types": "workspace:^7.13.0"
},
"devDependencies": {
"@babel/traverse": "workspace:^7.13.0"
}
}
14 changes: 14 additions & 0 deletions packages/babel-helper-hoist-variables/tsconfig.json
@@ -0,0 +1,14 @@
{
"generated": false,
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"outDir": "./lib",
"rootDir": "./src"
},
"include": ["./src/**/*"],
"references": [
{
"path": "../babel-types"
}
]
}

0 comments on commit 16c5ba6

Please sign in to comment.