fix: add optional: false to chained optional call expression (#11814)

babel · Jul 10, 2020 · 02c8fd9 · 02c8fd9
1 parent f32d5de
commit 02c8fd9
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 1 deletion.
diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js
@@ -660,8 +660,10 @@ export default class ExpressionParser extends LValParser {
       let node = this.startNodeAt(startPos, startLoc);
       node.callee = base;
 
+      if (state.optionalChainMember) {
+        node.optional = optional;
+      }
       if (optional) {
-        node.optional = true;
         node.arguments = this.parseCallExpressionArguments(tt.parenR, false);
       } else {
         node.arguments = this.parseCallExpressionArguments(

diff --git a/...babel-parser/test/fixtures/es2020/optional-chaining/optioanl-chain-expression/output.json b/...babel-parser/test/fixtures/es2020/optional-chaining/optioanl-chain-expression/output.json
@@ -39,6 +39,7 @@
             "computed": false,
             "optional": true
           },
+          "optional": false,
           "arguments": []
         }
       }

diff --git a/...ser/test/fixtures/experimental/class-private-properties/optional-chain-object/output.json b/...ser/test/fixtures/experimental/class-private-properties/optional-chain-object/output.json
@@ -257,6 +257,7 @@
                             "computed": false,
                             "optional": false
                           },
+                          "optional": false,
                           "arguments": [
                             {
                               "type": "NumericLiteral",
@@ -303,6 +304,7 @@
                             "computed": false,
                             "optional": false
                           },
+                          "optional": false,
                           "arguments": []
                         }
                       ]

diff --git a/...test/fixtures/experimental/class-private-properties/optional-chain-start-call/output.json b/...test/fixtures/experimental/class-private-properties/optional-chain-start-call/output.json
@@ -93,6 +93,7 @@
                         "computed": false,
                         "optional": true
                       },
+                      "optional": false,
                       "arguments": []
                     }
                   }

diff --git a/...xtures/experimental/class-private-properties/optional-chain-start-member-call/output.json b/...xtures/experimental/class-private-properties/optional-chain-start-member-call/output.json
@@ -99,6 +99,7 @@
                         "computed": false,
                         "optional": false
                       },
+                      "optional": false,
                       "arguments": [
                         {
                           "type": "NumericLiteral",