Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore identifiers in "export ... from" declarations #43

Closed
wants to merge 1 commit into from
Closed

Ignore identifiers in "export ... from" declarations #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/babel-helper-define-polyfill-provider/src/visitors/usage.js
View file
Open in desktop
Expand Up @@ -15,6 +15,14 @@ export default (
return {
// Symbol(), new Promise
ReferencedIdentifier(path: NodePath) {
if (
path.parentPath.isExportSpecifier() &&
path.parentPath.parent.source
) {
// export { Foo } from "module"
return;
}

const {
node: { name },
scope,
Expand Down
1 change: 1 addition & 0 deletions packages/babel-plugin-polyfill-corejs3/package.json
View file
Open in desktop
Expand Up @@ -23,6 +23,7 @@
"@babel/core": "^7.11.5",
"@babel/helper-plugin-test-runner": "^7.10.4",
"@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-syntax-export-default-from": "^7.12.1",
"@babel/plugin-transform-for-of": "^7.10.4",
"@babel/plugin-transform-modules-commonjs": "^7.10.4",
"core-js-pure": "^3.6.5"
Expand Down
2 changes: 2 additions & 0 deletions packages/babel-plugin-polyfill-corejs3/test/fixtures/usage-global/export-from/input.mjs
View file
Open in desktop
@@ -0,0 +1,2 @@
export { Set } from "foo";
export Map from "foo";
11 changes: 11 additions & 0 deletions packages/babel-plugin-polyfill-corejs3/test/fixtures/usage-global/export-from/options.json
View file
Open in desktop
@@ -0,0 +1,11 @@
{
"plugins": [
"@babel/plugin-syntax-export-default-from",
[
"@@/polyfill-corejs3",
{
"method": "usage-global"
}
]
]
}
2 changes: 2 additions & 0 deletions packages/babel-plugin-polyfill-corejs3/test/fixtures/usage-global/export-from/output.mjs
View file
Open in desktop
@@ -0,0 +1,2 @@
export { Set } from "foo";
export Map from "foo";
2 changes: 2 additions & 0 deletions packages/babel-plugin-polyfill-corejs3/test/fixtures/usage-pure/export-from/input.mjs
View file
Open in desktop
@@ -0,0 +1,2 @@
export { Set } from "foo";
export Map from "foo";
11 changes: 11 additions & 0 deletions packages/babel-plugin-polyfill-corejs3/test/fixtures/usage-pure/export-from/options.json
View file
Open in desktop
@@ -0,0 +1,11 @@
{
"plugins": [
"@babel/plugin-syntax-export-default-from",
[
"@@/polyfill-corejs3",
{
"method": "usage-pure"
}
]
]
}
2 changes: 2 additions & 0 deletions packages/babel-plugin-polyfill-corejs3/test/fixtures/usage-pure/export-from/output.mjs
View file
Open in desktop
@@ -0,0 +1,2 @@
export { Set } from "foo";
export Map from "foo";
1 change: 1 addition & 0 deletions packages/babel-plugin-polyfill-es-shims/test/fixtures/usage-global/export-from/input.mjs
View file
Open in desktop
@@ -0,0 +1 @@
export { AggregateError } from "foo";
15 changes: 15 additions & 0 deletions packages/babel-plugin-polyfill-es-shims/test/fixtures/usage-global/export-from/options.json
View file
Open in desktop
@@ -0,0 +1,15 @@
{
"validateLogs": true,
"plugins": [
[
"@@/polyfill-es-shims",
{
"method": "usage-global",
"missingDependencies": {
"log": "per-file",
"all": true
}
}
]
]
}
1 change: 1 addition & 0 deletions packages/babel-plugin-polyfill-es-shims/test/fixtures/usage-global/export-from/output.mjs
View file
Open in desktop
@@ -0,0 +1 @@
export { AggregateError } from "foo";
1 change: 1 addition & 0 deletions packages/babel-plugin-polyfill-es-shims/test/fixtures/usage-pure/export-from/input.mjs
View file
Open in desktop
@@ -0,0 +1 @@
export { AggregateError } from "foo";
15 changes: 15 additions & 0 deletions packages/babel-plugin-polyfill-es-shims/test/fixtures/usage-pure/export-from/options.json
View file
Open in desktop
@@ -0,0 +1,15 @@
{
"validateLogs": true,
"plugins": [
[
"@@/polyfill-es-shims",
{
"method": "usage-pure",
"missingDependencies": {
"log": "per-file",
"all": true
}
}
]
]
}
1 change: 1 addition & 0 deletions packages/babel-plugin-polyfill-es-shims/test/fixtures/usage-pure/export-from/output.mjs
View file
Open in desktop
@@ -0,0 +1 @@
export { AggregateError } from "foo";
22 changes: 17 additions & 5 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -166,7 +166,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/helper-define-polyfill-provider@^0.0.4, @babel/helper-define-polyfill-provider@workspace:packages/babel-helper-define-polyfill-provider":
"@babel/helper-define-polyfill-provider@^0.0.5, @babel/helper-define-polyfill-provider@workspace:packages/babel-helper-define-polyfill-provider":
version: 0.0.0-use.local
resolution: "@babel/helper-define-polyfill-provider@workspace:packages/babel-helper-define-polyfill-provider"
dependencies:
Expand Down Expand Up @@ -619,6 +619,17 @@ __metadata:
languageName: node
linkType: hard

"@babel/plugin-syntax-export-default-from@npm:^7.12.1":
version: 7.12.1
resolution: "@babel/plugin-syntax-export-default-from@npm:7.12.1"
dependencies:
"@babel/helper-plugin-utils": ^7.10.4
peerDependencies:
"@babel/core": ^7.0.0-0
checksum: 2fb7cd269beb9bb662e68358fa250fdfc110664c03dd47e6b5d884d56f2d2227510b86ff16d0ff0fefb901b5050dfb60501f4314710fe1702f29ca1e87e2eee6
languageName: node
linkType: hard

"@babel/plugin-syntax-export-namespace-from@npm:^7.8.3":
version: 7.8.3
resolution: "@babel/plugin-syntax-export-namespace-from@npm:7.8.3"
Expand Down Expand Up @@ -3596,7 +3607,7 @@ __metadata:
dependencies:
"@babel/compat-data": ^7.11.0
"@babel/core": ^7.11.5
"@babel/helper-define-polyfill-provider": ^0.0.4
"@babel/helper-define-polyfill-provider": ^0.0.5
"@babel/helper-plugin-test-runner": ^7.10.4
"@babel/plugin-transform-for-of": ^7.10.4
"@babel/plugin-transform-modules-commonjs": ^7.10.4
Expand All @@ -3611,9 +3622,10 @@ __metadata:
resolution: "babel-plugin-polyfill-corejs3@workspace:packages/babel-plugin-polyfill-corejs3"
dependencies:
"@babel/core": ^7.11.5
"@babel/helper-define-polyfill-provider": ^0.0.4
"@babel/helper-define-polyfill-provider": ^0.0.5
"@babel/helper-plugin-test-runner": ^7.10.4
"@babel/plugin-syntax-dynamic-import": ^7.8.3
"@babel/plugin-syntax-export-default-from": ^7.12.1
"@babel/plugin-transform-for-of": ^7.10.4
"@babel/plugin-transform-modules-commonjs": ^7.10.4
core-js-compat: ^3.7.0
Expand All @@ -3628,7 +3640,7 @@ __metadata:
resolution: "babel-plugin-polyfill-es-shims@workspace:packages/babel-plugin-polyfill-es-shims"
dependencies:
"@babel/core": ^7.11.5
"@babel/helper-define-polyfill-provider": ^0.0.4
"@babel/helper-define-polyfill-provider": ^0.0.5
"@babel/helper-plugin-test-runner": ^7.10.4
array.from: ^1.1.0
peerDependencies:
Expand All @@ -3641,7 +3653,7 @@ __metadata:
resolution: "babel-plugin-polyfill-regenerator@workspace:packages/babel-plugin-polyfill-regenerator"
dependencies:
"@babel/core": ^7.11.5
"@babel/helper-define-polyfill-provider": ^0.0.4
"@babel/helper-define-polyfill-provider": ^0.0.5
"@babel/helper-plugin-test-runner": ^7.10.4
peerDependencies:
"@babel/core": ^7.0.0-0
Expand Down