New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update core-js
#138
Update core-js
#138
Conversation
"esnext.array.find-last-index", | ||
"esnext.typed-array.find-last", | ||
"esnext.typed-array.find-last-index", | ||
"esnext.array.to-reversed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it already available in some browsers by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generated automatically, so yes, it's available in some environments by default. It's not a browser, it's bun
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But preset-env
's shippedProposals does not include bun
. Until preset-env
recognizes bun
as shippedProposals, can we exclude bun
here?
if (Object.keys(compatData[feature]).length === 0) continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it should be solved on the preset-env
side, babel/babel#14831.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this proposal is supported in Safari 16 that's released today. If you wanna change something in the shippedProposals
logic - feel free to do it out of the scope of this PR - I think that the current logic of considering something as "shipped" is incorrect anyway.
Merged in 1f2008f |
@nicolo-ribaudo why I wrote that the way of considering something as "shipped" is incorrect? It's not even the definition of "shipped". Safari 16 implements the "change array by copy" proposal - all actual methods. However, in the proposal recently was changed the order of errors in It should be added too. |
@zloirock I'm happy to delegate the decision of what counts as shipped to you: do you know where we can get the "is this supported enough, even if with bugs, to consider it as shipped" data? |
@zloirock at this moment we could only manually support this list. |
Note that apparently I forgot to run |
Yep, since it's fixed in Safari TP / Bun. |
No description provided.