Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showcase sample configs with respect to .mjs #682

Closed
wants to merge 1 commit into from

Conversation

capaj
Copy link

@capaj capaj commented Sep 20, 2018

as mentioned https://twitter.com/capajj/status/1042836215022735361 we need to transpile .mjs files as well. Having this regex like this by default will save countless developers from wondering why their bundle has fat arrows and other ES6 features.

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: documentation improvement

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:
please ask if anything is unclear, I'll gladly try to explain more.

as mentioned https://twitter.com/capajj/status/1042836215022735361 we need to transpile .mjs files as well. Having this regex like this by default will save countless developers from wondering why their bundle has fat arrows and other ES6 features.
@loganfsmyth
Copy link
Member

This is now done with #683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants