This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Revert 584 #697
Merged
Revert 584 #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
* Revert "Treat type alias declarationlike function declaration (babel/babel-eslint#584)" This reverts commit 020d012c554913fea137f4129798ce31a4896dfe.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #691
Reverts #584
We'll need to figure out a better approach than converting a
TypeAliasinto a Function Declaration. I guess it kind of made sense because I assume the reason for the original issue is that you are using it before define (and for functions they are hoisted and it's ok to use them before defined). So we need to make a decision on if we want these TypeAlias to act like functions.Will need to re-open #485 then.