Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recolor state borders #110

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Recolor state borders #110

merged 2 commits into from
Apr 13, 2023

Conversation

travissouthard
Copy link
Contributor

@travissouthard travissouthard commented Apr 13, 2023

Overview

Changes the state borders to white and the fill color of states with no funding to light gray.

Closes #73

Demo

image

Testing Instructions

  • In this branch run ./scripts/server and navigate to http://localhost:8765/
  • Ensure:
    • The states' border colors are white
    • They are also white when hovered/mouseover'd
    • In the "Civil Works" tab: NV, UT, CO, NH, RI, & DE are light gray with white borders

Checklist

  • fixup! commits have been squashed
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
  • README.md updated if necessary to reflect the changes
  • CI passes after rebase

@github-actions
Copy link

github-actions bot commented Apr 13, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.01s
✅ BASH shfmt 11 0 0.0s
✅ JAVASCRIPT eslint 45 0 3.49s
✅ JAVASCRIPT prettier 45 0 2.44s
✅ JSON eslint-plugin-jsonc 4 0 0.75s
✅ JSON jsonlint 4 0 0.16s
✅ SPELL misspell 90 0 0.1s
✅ TERRAFORM terraform-fmt 5 0 0.24s
✅ YAML yamllint 5 0 0.25s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Would you be able to add the drop shadow that Sophie mentioned here?

@travissouthard
Copy link
Contributor Author

travissouthard commented Apr 13, 2023

Nice. Would you be able to add the drop shadow that Sophie mentioned here?

I made an issue #111 to add the drop shadow specifically so that we can get that together, but we did both agree earlier in person that this is outside the scope of this card.

@travissouthard travissouthard merged commit de9a814 into develop Apr 13, 2023
3 checks passed
@travissouthard travissouthard deleted the ts/recolor-state-borders branch April 13, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change hover outline color
2 participants