Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color palette to green #102

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Change color palette to green #102

merged 2 commits into from
Apr 12, 2023

Conversation

jacobtylerwalls
Copy link
Contributor

@jacobtylerwalls jacobtylerwalls commented Apr 11, 2023

Overview

Change to green color scheme.

Closes #93

Demo

Screenshot 2023-04-11 at 11 28 21 AM

Screenshot 2023-04-11 at 11 23 05 AM

Notes

  • Like before, the tooltip color is outside the rest of the color scheme. I thought this was by design, so I chose a new green that seemed analogous to the old blue.
  • The animated arcs also needed a new green, so I chose the actual color of US legal tender as a placeholder. I'm not committed to this choice.

Testing Instructions

  • scripts/server

I also went ahead and deployed this so that the team could more easily have a look.

Checklist

  • fixup! commits have been squashed
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
  • README.md updated if necessary to reflect the changes
  • CI passes after rebase

@github-actions
Copy link

github-actions bot commented Apr 11, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.02s
✅ BASH shfmt 11 0 0.01s
✅ JAVASCRIPT eslint 43 0 3.5s
✅ JAVASCRIPT prettier 43 0 2.38s
✅ JSON eslint-plugin-jsonc 4 0 0.72s
✅ JSON jsonlint 4 0 0.14s
✅ SPELL misspell 88 0 0.09s
✅ TERRAFORM terraform-fmt 5 0 0.23s
✅ YAML yamllint 5 0 0.24s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@travissouthard travissouthard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well and looking nice. From browsing through it looks like the only component (beside AnimatedArcAndMap.tsx) that is still using it's own hardcoded colors is AnimatedMapLegend.tsx that doesn't look like it's being used by any other component and could be removed I think (unless you have plans for it).

The only other thing I noted was a note about color/key naming in the theming, but that decision may need to be between the devs and UX, but otherwise this is good to go.

@@ -38,7 +38,7 @@ export default function useCreateArcPath(
arcPathsReference.current[state] = new L.Curve(
['M', DC_CENTER, 'Q', midpoint, polygonCenterTuple],
{
color: '#2051FF',
color: '#85bb65', // the actual shade of US legal tender :-O
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a bit of an arbitrary choice but this does make a good color for this palette.

Also more emoticons in comments please

Comment on lines +44 to +50
green: {
50: '#F1F8F3',
100: '#DEECE2',
300: '#ADCDB7',
600: '#3DA45A',
900: '#235F34',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Centralizing the colors like this is an excellent choice and will absolutely make things easier to keep track of.

However, while I understand the use of the number keys coordinating with the numbers in the FIGMA design; Using semantic names may help devs more easily remember what is available and which colors are which (e.g. 'light', 'medium', 'dark')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I'm only parroting what I'm used to from azavea/iow-boundary-tool. I can imagine with six or seven shades that 'medium' becomes less helpful (extra medium?) I'm wondering if you contemplated that on any other projects?

Chakra also guides toward numbers: https://chakra-ui.com/docs/styled-system/theme

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we made that choice in a recent Civic Apps project, but can't find the example I was looking for, but also for that we had 5 distinct colors with a light and dark variant, so that may not apply here since this is a monochromatic gradient.

@jacobtylerwalls
Copy link
Contributor Author

Good spot, that legend was completely obviated by f38746d, so I'll remove it.

@jacobtylerwalls jacobtylerwalls merged commit 411cb5f into develop Apr 12, 2023
3 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jw/green branch April 12, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert page to green color schema
2 participants