bpf: Maps live in maps section #248
Conversation
|
Note to self: add userspace component to the test case that uses the maps... |
| @@ -49,11 +49,13 @@ impl Map { | |||
| } | |||
|
|
|||
| pub fn expand(&self) -> Result<TokenStream> { | |||
| let section_name = format!("maps/{}", self.name); | |||
| let section_name = "maps".to_string(); | |||
There was a problem hiding this comment.
libbpf expects maps live in .maps section.
There was a problem hiding this comment.
It only expects them in .maps BTF maps.
But that being said, I think we need a way to specify it by using this macro.
I'm not suggesting it's the right PR to do this, it might be add as part of BTF map support.
There was a problem hiding this comment.
The legacy one is deprecated.
There was a problem hiding this comment.
The legacy, bpf_map_def style of map definition is the only style that we support in aya-bpf right now.
But that being said, I think we need a way to specify it by using this macro.
Not really. If we supported BTF defs, all maps would use BTF map defs.
I'm not sure if libbpf's deprecation notice means support will be removed from the kernel (I doubt it) or whether it's to give users a push to use BTF.
Anyhow, userspace support for BTF maps is proposed in #140 but still needs work.
Support in aya-bpf for BTF maps is sadly not as simple as the BTF generated for Rust programs by LLVM isn't correct.
dave-tucker
added
fix
This forces all maps to the maps section so we remain compatible with libbpf. This requires aya-rs#181 to avoid breaking userspace. Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
This forces all maps to the maps section so we remain compatible with
libbpf. This requires #181 to avoid breaking userspace.
Signed-off-by: Dave Tucker dave@dtucker.co.uk