Allow swagger to use overridden CSRF settings and read the CSRF cookie #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
force-pushed
the
allow-swagger-to-use-custom-csrf-settings
branch
3 times, most recently
from
c098a02
to
0d7c8cf
Compare
terencehonles
commented
Oct 26, 2020
There was a problem hiding this comment.
@axnsan12 this should also be a pretty easy PR to review, I bumped it to run the CI tests again.
| @@ -33,6 +33,8 @@ | |||
| 'DEFAULT_API_URL': None, | |||
|
|
|||
| 'USE_SESSION_AUTH': True, | |||
| 'CSRF_COOKIE_NAME': settings.CSRF_COOKIE_NAME, | |||
There was a problem hiding this comment.
I'm pretty sure these will be available, but I can change this to gettar like below if that is preferred.
terencehonles
force-pushed
the
allow-swagger-to-use-custom-csrf-settings
branch
from
0d7c8cf
to
17aecc3
Compare
|
@johnthagen it looks like you might also have commit access to the repo? Do you mind reviewing? I just update the changes and kicked off the CI. |
terencehonles
force-pushed
the
allow-swagger-to-use-custom-csrf-settings
branch
from
17aecc3
to
2697326
Compare
|
@axnsan12 any chance I can get a review on this / have this merged? |
|
I’ll review this now |
JoelLefkowitz
added
1.21.x
terencehonles
force-pushed
the
allow-swagger-to-use-custom-csrf-settings
branch
from
91e871a
to
3c14a2c
Compare
|
updated this to the latest version of |
terencehonles
force-pushed
the
allow-swagger-to-use-custom-csrf-settings
branch
from
3c14a2c
to
06debd7
Compare
terencehonles
force-pushed
the
allow-swagger-to-use-custom-csrf-settings
branch
from
06debd7
to
a2be3e5
Compare
|
updated this to the latest version of |
terencehonles
force-pushed
the
allow-swagger-to-use-custom-csrf-settings
branch
from
a2be3e5
to
271aa3d
Compare
terencehonles
force-pushed
the
allow-swagger-to-use-custom-csrf-settings
branch
from
271aa3d
to
fc9a9df
Compare
|
@terencehonles thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.