Fix retrieving model for reverse relations #573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
current util
get_related_model
implementation does not take into account that reverse relations (descriptor can be both forward and reverse) so for reverse relations it leads to bugs like this:New implementation robustly checks type of relation and returns appropriate model.
It supports all kind of descriptors:
OneToOne
,ManyToOne
,ManyToMany
.