Adds support to DEFAULT_JSON_ENCODER #483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelLefkowitz
added
1.21.x
JoelLefkowitz
added
1.22.x
|
Thank you for your PR! You only replaced it in utils, shouldn't the instances in renderers also be replaced? Also the docs will have to be updated for this additional setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've been using custom JSON encoders for a while with drf-yasg but haven't seen any support for it.
A while ago someone requested support for the django Decimal field and it was implemented. But i think this might be a simple solution if people want to use their own fields without needing to add custom code, just use their own encoder (which they probabbly they already have if they are using drf).
I'm willing to make any changes and validations you guys suggest and update the documentation.