handle enum type for nested ChoiceFields #400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
On a project I'm working on, I'm using Django
IntegerField
s, with achoices
parameter, nested in postgresArrayFields
. This translates to aListField
with a childChoiceField
in theModelSerializer
.The issue I'm having is that
ChoiceFieldInspector
fails to properly infer the resulting enum type, even though it could because it can guess it correctly forIntegerField
s:ChoiceField
has nosource
, it fails. I fixed it by usingparent.source
.ArrayField
soget_basic_type_info
doesn't return anything. I fixed it by using thebase_field
if present.This PR adds some code that fixes the issue & a test. Feel free to tell me if I solved the problem the wrong way; tests seem to pass so I don't think I broke anything.