Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the method parameter to lowercase #912

Closed
wants to merge 0 commits into from
Closed

Convert the method parameter to lowercase #912

wants to merge 0 commits into from

Conversation

luciy
Copy link
Contributor

@luciy luciy commented May 23, 2017

In some cases, passing Request Method in uppercase causes some errors.

Example:

axios.defaults.headers.post['Content-Type'] = 'application/x-www-form-urlencoded';

return axios({
  method: 'POST',
  url: url
});

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 93.734% when pulling 8f5872d on luciy:master into f31317a on mzabriskie:master.

@rubennorte
Copy link
Member

Nice feature. Could you please add a test for it?

@rubennorte rubennorte mentioned this pull request May 28, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.734% when pulling 9d45d2f on luciy:master into d1278df on mzabriskie:master.

@luciy
Copy link
Contributor Author

luciy commented May 31, 2017

add test

rubennorte
rubennorte reviewed May 31, 2017
View reviewed changes
test/specs/requests.spec.js Outdated
axios({
url: '/foo',
method: 'POST'
}).then(function (request) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter should be response

@rubennorte
Copy link
Member

Please don't commit changes to the files in dist. Could you undo them in the PR?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.734% when pulling 29903e2 on luciy:master into d1278df on mzabriskie:master.

@luciy luciy closed this May 31, 2017
@luciy luciy mentioned this pull request May 31, 2017
Merged
@luciy
Copy link
Contributor Author

luciy commented May 31, 2017

Resubmit the PR at #930

@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rubennorte rubennorte rubennorte left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luciy @coveralls @rubennorte