Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with isStandardBrowserEnv (#597) #650

Closed
wants to merge 1 commit into from

Conversation

eu81273
Copy link

@eu81273 eu81273 commented Jan 13, 2017

document.createElement is not function in Internet Explorer 8.
But isStandardBrowserEnv checks standard browser environment like below.

function isStandardBrowserEnv() {
  return (
    typeof window !== 'undefined' &&
    typeof document !== 'undefined' &&
    typeof document.createElement !== 'function'
  );
}

As I mentioned above, document.createElement is not function(is object) in Internet Explorer 8, so isStandardBrowserEnv determine wrong; and XDomainRequest is not working in IE8.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a87e0b7 on eu81273:master into ** on mzabriskie:master**.

@nickuraltsev
Copy link
Member

Closing in favor of #731.

@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants