Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(require): use require in the ES6 module #6311

Open
wants to merge 2 commits into
base: v1.x
Choose a base branch
from
Open

fix(require): use require in the ES6 module #6311

wants to merge 2 commits into from

Conversation

bstashchuk
Copy link

Fixing bug with examples

In the ES6 module examples/server.js require (CommonJS syntax) was called.
Needs to be replaced with import.

Steps to reproduce:

  • Run examples script npm run examples
  • In the web browser navigate to http://localhost:3000/get
  • Server will crash with error require is not defined

There were no tests for examples, so, no changes in tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bstashchuk