Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): export CJS types from ESM #6218

Open
wants to merge 2 commits into
base: v1.x
Choose a base branch
from
Open

fix(types): export CJS types from ESM #6218

wants to merge 2 commits into from

Conversation

remcohaszing
Copy link
Contributor

This prevents discrepancies between those from occurring.

See arthurfiorette/axios-cache-interceptor#778

@remcohaszing
fix(types): export CJS types from ESM
5ddb3cb 
This prevents discrepancies between those from occurring.
@arthurfiorette

This comment has been minimized.

Sign in to view
@remcohaszing
Copy link
Contributor Author

You can’t use export * to re-export from a module that uses export =. But even if you could, that would be incorrect. Not all members of the axios static instance are exported from the axios ESM module as named exports.

The default export in index.d.ts is on line 67.

jasonsaayman
jasonsaayman approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remcohaszing thanks so much for this 🙌

@giorgiosironi giorgiosironi mentioned this pull request Feb 20, 2024
Closed
@erkannt
Copy link

erkannt commented Mar 21, 2024

Have confirmed that this change would fix the issue for sciety/sciety. Eagerly awaiting its release 😇

@arthurfiorette
Copy link
Contributor

Hey @jasonsaayman, can you review this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonsaayman jasonsaayman jasonsaayman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@remcohaszing @arthurfiorette @erkannt @jasonsaayman