fix(params): removing '[' and ']' from URL encode exclude characters … #5715
+5
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillianAgostini
approved these changes
May 26, 2023
|
@jasonsaayman Please take a look at this PR. This bug has been waiting to be fixed for over 4 years :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3316
According to RFC 3986, square brackets in URLs must be encoded.
So I modified the encoding behavior to fit the spec.
Karma tests can fail, but that's not a problem with my code, it's an issue with an external service that the test utilizes. (see #5714)